From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030692AbeAON6n (ORCPT + 1 other); Mon, 15 Jan 2018 08:58:43 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:8956 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965790AbeAON6i (ORCPT ); Mon, 15 Jan 2018 08:58:38 -0500 X-IronPort-AV: E=Sophos;i="5.46,363,1511823600"; d="scan'208";a="251251950" Date: Mon, 15 Jan 2018 14:58:25 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Thierry Reding cc: Thierry Reding , David Airlie , nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, kbuild-all@01.org, Ben Skeggs Subject: Re: [Nouveau] [PATCH] fix drm-get-put.cocci warnings In-Reply-To: <20180115135102.GA5519@ulmo> Message-ID: References: <20180115135102.GA5519@ulmo> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, 15 Jan 2018, Thierry Reding wrote: > On Mon, Jan 15, 2018 at 01:47:07PM +0100, Julia Lawall wrote: > > From: Fengguang Wu > > > > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and > > drm_*_unreference() helpers. > > > > Generated by: scripts/coccinelle/api/drm-get-put.cocci > > > > Signed-off-by: Fengguang Wu > > Signed-off-by: Julia Lawall > > --- > > > > tree: https://github.com/thierryreding/linux for-4.16/work > > head: 6c86494bb2f670293f6137b0a4b3c53c8886eba4 > > commit: 34f022b2d11f91a323d3e7d15893d480646f3fad [149/161] WIP > > > > nouveau_gem.c | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > Hi Julia, > > thanks for the patch. However, the tree that you generated it against is > a personal development tree and it happens to have a bunch of commits in > it that are very experimental and some of which are very unlikely to go > upstream. There's an IOCTL addition patch (touched by hunk 7 in this > patch) that is used only for testing purposes. All of the other hunks do > pply properly to linux-next, so I think those can be posted. Nouveau is > maintained by Ben Skeggs, though, so they should be addressed to him. > > I don't personally mind getting these patches, and I don't mind people > seeing the personal development tree (it's publicly available, after > all) but I think patches against this tree will be confusing to anyone > but me because they are likely not going to apply anywhere other than > that tree. OK, I'm just forwarding what kbuild sends me for approval. No problem if you toss it, apply it, or do whatever seems reasonable :) julia > > Thanks, > Thierry >