From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBov9DvAWqlQ3CR2OdyZtAuCeObNIUuWIxiUcepb05mUW1wy6FugfcKUeri/g5ju3hj24egx+ ARC-Seal: i=1; a=rsa-sha256; t=1516297199; cv=none; d=google.com; s=arc-20160816; b=aJ+efArDhAbun4Z/Z3VXgx749+rpJ1lItbnLurds2zhy0ubMA5ds6ovTLO+lYSqNHP U1zQBKJZwwXkNKfgrLN1uOs9e7H29VF2VOCTUeyctQeCN9DwlLVFzR+V+qsv67dmTYAV TfJgRBflAcN2ARknGvvTpiVpZdGTSWfG2Ui3n553faVrbw6ctBv/OuhxDBq3G0Loe0Nd VTLhQLTHH6KOt4mZ6l1Db5A2BMp9rwZDEKvFwLTYOrSt8+8lZX9ZEhQwtMAE/cuT9UOx jFOUCnXcLudvDaJO8k61lbDF6FVOvXP27dtCGFbzZI28+v8oZtLrN2LuO0Kp602K4rps 0Iig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:arc-authentication-results; bh=02FaA7SygJr2i2hAHLVbP3jtGB0R7uO0pAqzZx6DpWY=; b=X7fSWbrRC3VoflLjNHb0D+urFEimwyEK2e36N4I6dK5LrSM61mqBoqeQt0UcHcxUzZ 8ZfyHdhdGczTpGFSomsKL0oQU8Qi0BtQdsl3ynU7swPge/6rCQnj6XKCZK1UcF4/UgPB ffGdj8oq3mCi+3wmSkILUjhNFmqtKSMVdjYxAHGl8A0NpELkI0Ysq0/6mA1b2biT3VOa tOx6KlUFoLhP1bwYQQhQfPZzTnJjc8AP0xCzZUpItUtJjron+G7NUcAJuDsbYCiZ85bn L4ZnKJ+LjGTHB1webhJnID3aL/N9msTY2jvtkAv5Ta6y9PgQDEX9WgjnEXcg+m9ERLpY z/oQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of tglx@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) smtp.mailfrom=tglx@linutronix.de Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of tglx@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) smtp.mailfrom=tglx@linutronix.de Date: Thu, 18 Jan 2018 18:39:50 +0100 (CET) From: Thomas Gleixner To: Josh Poimboeuf cc: tip-bot for Andi Kleen , linux-tip-commits@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, ak@linux.intel.com, dwmw@amazon.co.uk, mingo@kernel.org, hpa@zytor.com Subject: Re: [tip:x86/pti] module: Add retpoline tag to VERMAGIC In-Reply-To: <20180118170255.wgcqrqiflikd3tmz@treble> Message-ID: References: <20180116205228.4890-1-andi@firstfloor.org> <20180118170255.wgcqrqiflikd3tmz@treble> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589836015920876400?= X-GMAIL-MSGID: =?utf-8?q?1589952852831542056?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Thu, 18 Jan 2018, Josh Poimboeuf wrote: > On Wed, Jan 17, 2018 at 02:40:43AM -0800, tip-bot for Andi Kleen wrote: > > Commit-ID: 6cfb521ac0d5b97470883ff9b7facae264b7ab12 > > Gitweb: https://git.kernel.org/tip/6cfb521ac0d5b97470883ff9b7facae264b7ab12 > > Author: Andi Kleen > > AuthorDate: Tue, 16 Jan 2018 12:52:28 -0800 > > Committer: Thomas Gleixner > > CommitDate: Wed, 17 Jan 2018 11:35:14 +0100 > > > > module: Add retpoline tag to VERMAGIC > > > > Add a marker for retpoline to the module VERMAGIC. This catches the case > > when a non RETPOLINE compiled module gets loaded into a retpoline kernel, > > making it insecure. > > > > It doesn't handle the case when retpoline has been runtime disabled. Even > > in this case the match of the retcompile status will be enforced. This > > implies that even with retpoline run time disabled all modules loaded need > > to be recompiled. > > If the user overrides the vermagic and loads the module, shouldn't we > update the spectre_v2 sysfs vulnerability status and print a warning > like in v2? If the user does that then the sysfs output is not our problem anymore, really. Thanks, tglx