From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751473AbeAYJGz (ORCPT ); Thu, 25 Jan 2018 04:06:55 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:34229 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751295AbeAYJGw (ORCPT ); Thu, 25 Jan 2018 04:06:52 -0500 Date: Thu, 25 Jan 2018 10:05:57 +0100 (CET) From: Thomas Gleixner To: Palmer Dabbelt cc: linux@armlinux.org.uk, catalin.marinas@arm.com, Will Deacon , jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, Christoph Hellwig , Arnd Bergmann , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, patches@groups.riscv.org Subject: Re: [PATCH v2 1/4] arm: Make set_handle_irq and handle_arch_irq generic In-Reply-To: <20180125030756.21787-2-palmer@sifive.com> Message-ID: References: <20180125030756.21787-1-palmer@sifive.com> <20180125030756.21787-2-palmer@sifive.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 24 Jan 2018, Palmer Dabbelt wrote: > It looks like this same irqchip registration mechanism has been copied > into a handful of ports, including aarch64 and openrisc. I want to use > this in the RISC-V port, so I thought it would be good to make this > generic instead. > > This patch simply moves set_handle_irq and handle_arch_irq from arch/arm > to kernel/irq/handle.c. > > Signed-off-by: Palmer Dabbelt > --- > arch/arm/Kconfig | 5 ----- > arch/arm/include/asm/irq.h | 5 ----- > arch/arm/kernel/entry-armv.S | 6 ------ > arch/arm/kernel/irq.c | 10 ---------- > include/linux/irq.h | 18 ++++++++++++++++++ > kernel/irq/Kconfig | 5 +++++ > kernel/irq/handle.c | 10 ++++++++++ Please split the patches into two pieces: 1) Add the infrastructure to the generic code and have a new Kconfig symbol GENERIC_IRQ_MULTI_HANDLER or something which fits in the GENERIC_IRQ_ name space. That also makes sure that the build does not fail after patch 1 for the non converted arch. With your change this breaks arm64 build with only patch 1 applied because the Kconfig symbol is defined twice and the code is defined twice. See drivers/irqchip/Kconfig ARM_GIC_V3 .... 2) Convert both arm and arm64 over along with the select statements in the arch and irqchip Kconfigs Thanks, tglx