From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-4102622-1516889017-2-1093185222391399491 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='de', MailFrom='org' X-Spam-charsets: plain='US-ASCII' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516889016; b=Pqtq6R+OadIGuWgCji1cmb07l7Faaht4WdAHyCU16k6SIzK cn1yDfC+3wj8uQyqQYZOW1v3g/QI5EZCTBxcQihM8p97mA7SvBSWKkEC3jzJwklX 1935UsDEJfOH5yq+M/OSdJl1AP+qD8quPzLuIsUkGCta9vbTON7y1kKmTtwcBLYn nyBbPP1+MPPjXw+QZ8LVWOqLhQ7wNs8Gg6LN9EKyXw29Wxew9c64skyyI5QSKchQ cBLK1Q9z4oMbYl0K6LprGl7PuGLP0rlxknNfOGRK5NVHy9Vv3GMGxiZV7wtk9Y+R ELrkov5vrzdqGBkZro3JLGk1MHqRkUbvI3nVZSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:in-reply-to :message-id:references:mime-version:content-type:sender:list-id; s=arctest; t=1516889016; bh=5ZQlf8E5/s9iOSC/JVtjnbIEjdQ8c44ym5+ kkFE6DAE=; b=fBtITCNaF5ff8q8lG2vkPhIaMIrRGKfoY3x8oMWjJYX+FP6xMlR xBVaZpyjSRZdPTw6tPcf+1XaK5vVxiplrD/uOc7t9/Ut0qVyrjBbAsxzFYkkloJa wgAEM0YgsetS0OmXeEf+izoK6Jl0p8EYY7g9ct+G/x9R2F4DuvWL38kPbQL6/4V1 V+JLma5bFfgWyb3SuuklgIPeTvVpcroOgV6xJMT4a//Pkc2s2Wq3qs3o9ipdr8a6 muOtxOBg8gAfFq0dgIGG7TbEt94xlGaEKMX0hQP5bB5JVoXYDWTmvg/PzT3aLL6F S/37gLVwuI7cBvD72KV3OPKkA/Y+o69wAyQ== ARC-Authentication-Results: i=1; mx6.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linutronix.de; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linutronix.de header.result=pass header_is_org_domain=yes Authentication-Results: mx6.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linutronix.de; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linutronix.de header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751437AbeAYODU (ORCPT ); Thu, 25 Jan 2018 09:03:20 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:35194 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751500AbeAYODS (ORCPT ); Thu, 25 Jan 2018 09:03:18 -0500 Date: Thu, 25 Jan 2018 15:03:13 +0100 (CET) From: Thomas Gleixner To: Jiri Slaby cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Li Jinyue , peterz@infradead.org, dvhart@infradead.org Subject: Re: [PATCH 4.14 17/89] futex: Prevent overflow by strengthen input validation In-Reply-To: <20567b49-e0a3-e9e0-d520-74bbfc20d414@suse.cz> Message-ID: References: <20180122083954.683903493@linuxfoundation.org> <20180122083956.427607580@linuxfoundation.org> <20567b49-e0a3-e9e0-d520-74bbfc20d414@suse.cz> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Thu, 25 Jan 2018, Jiri Slaby wrote: > On 01/22/2018, 09:44 AM, Greg Kroah-Hartman wrote: > > + if (nr_wake < 0 || nr_requeue < 0) > > + return -EINVAL; > > This breaks strace's test suite on 4.14.15 (and is present in upstream > obviously too): > futex(0x7ff568b44ffc, 0x3, 0xfacefeed, 0xbadda7a0ca7b100d, > 0x7ff568b44ffc, 0x9caffee1) = -1: Invalid argument And why the hell is strace expecting this to be valid? Thanks, tglx