From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-4102622-1516890643-2-16690198549984362921 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='de', MailFrom='org' X-Spam-charsets: plain='US-ASCII' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516890643; b=glnnhsUC1wu0yhrR7+KzVNnwiabZ3aL4hG+ltLmT4/Xy4NQ ZfoTYMng9buFEZyz4SpNZYFc36n4nohbl8weMesqugHHJa2e3AlTK7chpMIEg9ZW V5UZSlen0xA8ZN5fSPoLRRXLYpvIlX0zLIz152RQszRrfPpGILFhiEafA4BFPRV0 IqYA63K0HLGvkkqoc5+N7BZteR7V63iqg67iy+hd+tzVXAu+IULmLnlkSb5ATWeo u8fx8BernWCdu+bIpJFnCellMlwJtunFS6SkWXMzIcZMc8eMpzcY0NlkUthUnupn afAt8J+zpETGvscPbkjFqwO9XRA8Bigvfrrl0qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:in-reply-to :message-id:references:mime-version:content-type:sender:list-id; s=arctest; t=1516890643; bh=NZ3/lVeOPzfhnbUgfBrwbm6Msf+0D5CW4xg UxgW92LM=; b=d4VRORXw9n0yh4CA1jxpBY8lpeGsr/QZaZgez0Ylv5b4VsLmSf6 KuYIxgcgBIIBrW/JNITBCAG9/f3Wep6h5apsS2i+L5Wc+jGdC5amBCCso5b99WxG F1sC6jj1ePbJlVz62DZSN0bXkKixqkBROE62vqPLr8lzaVjQEyj7E+AiahGgidvs TakjekQLXNubFUSDepZ3Vvy1xDRGBsJeWymGuoa1wWXo+dX908c69dSiFVQzWjkA bkqgMao1ZSaQyonn7xlGdu2HYaCbt9XlnzlYxzXldjK8EfUv9bCfkqMFoH+pI/u3 4+2dYWL+PTxwWBK552/h9KRIIcwCPnQDmZg== ARC-Authentication-Results: i=1; mx1.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linutronix.de; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linutronix.de header.result=pass header_is_org_domain=yes Authentication-Results: mx1.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linutronix.de; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linutronix.de header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751488AbeAYOam (ORCPT ); Thu, 25 Jan 2018 09:30:42 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:35259 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125AbeAYOal (ORCPT ); Thu, 25 Jan 2018 09:30:41 -0500 Date: Thu, 25 Jan 2018 15:30:36 +0100 (CET) From: Thomas Gleixner To: Jiri Slaby cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Li Jinyue , peterz@infradead.org, dvhart@infradead.org Subject: Re: [PATCH 4.14 17/89] futex: Prevent overflow by strengthen input validation In-Reply-To: Message-ID: References: <20180122083954.683903493@linuxfoundation.org> <20180122083956.427607580@linuxfoundation.org> <20567b49-e0a3-e9e0-d520-74bbfc20d414@suse.cz> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Thu, 25 Jan 2018, Jiri Slaby wrote: > On 01/25/2018, 03:03 PM, Thomas Gleixner wrote: > > On Thu, 25 Jan 2018, Jiri Slaby wrote: > >> On 01/22/2018, 09:44 AM, Greg Kroah-Hartman wrote: > >>> + if (nr_wake < 0 || nr_requeue < 0) > >>> + return -EINVAL; > >> > >> This breaks strace's test suite on 4.14.15 (and is present in upstream > >> obviously too): > >> futex(0x7ff568b44ffc, 0x3, 0xfacefeed, 0xbadda7a0ca7b100d, > >> 0x7ff568b44ffc, 0x9caffee1) = -1: Invalid argument > > > > And why the hell is strace expecting this to be valid? > > You ought to ask somebody else, I was confused the very same way: > > My FIX: > https://github.com/strace/strace/pull/16/commits/777587ea509481666274df88671949b390f05cc3 > > Their NACK: > https://github.com/strace/strace/pull/16#issuecomment-341614984 https://github.com/strace/strace/commit/79d10dfc20985225e4ea044d3875c4cea09053d7 Update futex test in accordance with kernel's v4.15-rc7-202-gfbe0e83 * futex.c (VALP, VALP_PR, VAL2P, VAL2P_PR): New macro definitions. (main): Allow EINVAL on *REQUEUE* checks with VAL/VAL2 with higher bit being set, check that the existing behaviour preserved with VALP/VAL2P where higher bit is unset. So what's the problem? Thanks, tglx