From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932542AbeCBUAm (ORCPT ); Fri, 2 Mar 2018 15:00:42 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:14206 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932131AbeCBUAl (ORCPT ); Fri, 2 Mar 2018 15:00:41 -0500 X-IronPort-AV: E=Sophos;i="5.47,413,1515452400"; d="scan'208";a="316129501" Date: Fri, 2 Mar 2018 21:00:39 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Miquel Raynal cc: Boris Brezillon , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Cyrille Pitchen , Masahiro Yamada , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, kbuild-all@01.org Subject: [PATCH] mtd: rawnand: fix memdup.cocci warnings Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Fengguang Wu Use kmemdup rather than duplicating its implementation Generated by: scripts/coccinelle/api/memdup.cocci Signed-off-by: Fengguang Wu Signed-off-buy: Julia Lawall --- tree: https://github.com/bbrezillon/linux-0day mraynal/nand-scan head: 0fdb0ec57e123aae03d1c52f8ba5fb6c8c8f98ed commit: d4d20cd03273ee0d1bb874dc33170286216b6320 [70/71] mtd: rawnand: do not export nand_scan_[ident|tail]() anymore nand_base.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/mtd/nand/raw/nand_base.c +++ b/drivers/mtd/nand/raw/nand_base.c @@ -5160,13 +5160,12 @@ static int nand_flash_detect_onfi(struct sanitize_string(p->manufacturer, sizeof(p->manufacturer)); sanitize_string(p->model, sizeof(p->model)); - model = kzalloc(sizeof(p->model), GFP_KERNEL); + model = kmemdup(p->model, sizeof(p->model), GFP_KERNEL); if (!model) { ret = -ENOMEM; goto free_onfi_param_page; } - memcpy(model, p->model, sizeof(p->model)); chip->parameters.model = model; if (!mtd->name) mtd->name = chip->parameters.model;