From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752078AbeDJFto (ORCPT ); Tue, 10 Apr 2018 01:49:44 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:61507 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751589AbeDJFtn (ORCPT ); Tue, 10 Apr 2018 01:49:43 -0400 X-IronPort-AV: E=Sophos;i="5.48,430,1517871600"; d="scan'208";a="261452898" Date: Tue, 10 Apr 2018 07:49:40 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Hyun Kwon cc: Michal Simek , Laurent Pinchart , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kbuild-all@01.org Subject: [PATCH] drm: xlnx: pl_disp: fix odd_ptr_err.cocci warnings Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Fengguang Wu PTR_ERR should normally access the value just tested by IS_ERR Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci Fixes: 742243a44a73 ("drm: xlnx: pl_disp: Use xlnx pipeline calls") CC: Hyun Kwon Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v4.14 head: fe04d2ee0dfea6b5fdbb04f4f6dbcaa13bfd2fda commit: 742243a44a738b165f8da5cbdb6662139e85a5c5 [651/842] drm: xlnx: pl_disp: Use xlnx pipeline calls xlnx_pl_disp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/xlnx/xlnx_pl_disp.c +++ b/drivers/gpu/drm/xlnx/xlnx_pl_disp.c @@ -482,7 +482,7 @@ static int xlnx_pl_disp_probe(struct pla xlnx_pl_disp->master = xlnx_drm_pipeline_init(pdev); if (IS_ERR(xlnx_pl_disp->master)) { - ret = PTR_ERR(xlnx_pl_disp->dev); + ret = PTR_ERR(xlnx_pl_disp->master); dev_err(dev, "failed to initialize the drm pipeline\n"); goto err_component; }