From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753998AbeDPMYV (ORCPT ); Mon, 16 Apr 2018 08:24:21 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:2490 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753069AbeDPMYU (ORCPT ); Mon, 16 Apr 2018 08:24:20 -0400 X-IronPort-AV: E=Sophos;i="5.48,459,1517871600"; d="scan'208";a="323043917" Date: Mon, 16 Apr 2018 14:24:19 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Daniel Vetter cc: Joel Stanley , linux-aspeed@lists.ozlabs.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrew Jeffery , kbuild-all@01.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] drm: fix drm-get-put.cocci warnings In-Reply-To: <20180416074535.GH31310@phenom.ffwll.local> Message-ID: References: <20180416074535.GH31310@phenom.ffwll.local> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 Apr 2018, Daniel Vetter wrote: > On Thu, Apr 12, 2018 at 07:54:10AM +0200, Julia Lawall wrote: > > From: Fengguang Wu > > > > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and > > drm_*_unreference() helpers. > > > > Generated by: scripts/coccinelle/api/drm-get-put.cocci > > > > Fixes: 6784ac15bc68 ("drm: Add ASPEED GFX driver") > > Signed-off-by: Fengguang Wu > > Signed-off-by: Julia Lawall > > --- > > > > tree: https://github.com/shenki/linux drm-v1 > > This isn't an upstream tree (and the aspeed driver isn't in upstream > afaict), so no need for spamming mailing lists I think. Perhaps you can contact Fengguang about this? I just forward to whoever the automatically generated message says to forward to. And I don't always remember to include the information about the tree, which comes to me in another message, so it can indeed be confusing. > > But thanks for doing all this, great motivation to put more of the drm > refactorings into cocci files. Most welcome :) julia > Cheers, Daniel > > head: 9680ed7979d5d403c6bde36271a048d62c048180 > > commit: 6784ac15bc6889280522b04b97f1fb1208ee45e7 [23/27] drm: Add ASPEED > > GFX > > driver > > > > aspeed_gfx_drv.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > --- a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c > > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c > > @@ -268,7 +268,7 @@ static int aspeed_gfx_probe(struct platf > > err_unload: > > aspeed_gfx_unload(drm); > > err_free: > > - drm_dev_unref(drm); > > + drm_dev_put(drm); > > > > return ret; > > } > > @@ -279,7 +279,7 @@ static int aspeed_gfx_remove(struct plat > > > > drm_dev_unregister(drm); > > aspeed_gfx_unload(drm); > > - drm_dev_unref(drm); > > + drm_dev_put(drm); > > > > return 0; > > } > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch >