From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AB8JxZqw9bumJF4Ljt767NkCmL5/J0mc9xkRFK1FIxj9iHUNga1ulaR+AUPyFXnspUmh5CDnVbAm ARC-Seal: i=1; a=rsa-sha256; t=1524901490; cv=none; d=google.com; s=arc-20160816; b=Xi6NNGZtIqIP3NF9fmPyDyz61gAW4Zw2BYvSFhZM1lhnjKntgsoPDaJ2yuv4xt1GOx oTkYuIOfgCrwQFVBJAS31OAkUtvKZv8IM1A8Ci1P3nw7YzFbZyk+nL50eCGEDsjrI4dR bNK/f42Rohd9jCLYJ0mNod/8ZdOL8Rss2IrMKBWH1u9yxMz3tvCZQY2zGPI/f6br4aDX i7/wGGXd2NkixuXnRoO5RmsIXfFJ/0L0mSiP85y/Z5CCF2nJTDPxnbHpqOWCoJ/iYemI zTvX7cs3x/V54V6dwLYFvtR3kKDtggViPeDVLqrCBB9gISfQWzR87a1kYCAkP7+em/lK KsBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:message-id:subject:cc:to:from:date :arc-authentication-results; bh=1QM2inY+vGEYeGhm+VHZzX4j5JudNfNmV958Y2J2qSo=; b=WnGvvarb5QqmxdEhdd/oiIYLHdtGpKkfjps05eHJoZ/Ki+xJ5fmdk9er2v+rA4QT+I Upv3MCBAi4/Y2dysv5zpSJGO/o5A8U5VrP2xhgxp2RN2H9nACZYj6uNf5QPyUZ0VYUjU C+i0sqV8vqgbUBV/yFzN1HD+IKAT7dZc+EhI9sPyaA/Yv5PacoFklkpSrxgf7Rxs31CE T4hhTED3bkdciLlmtdhwOVUfVF0MIN5QvdVGvtg+q0uoE8RXiTykovWtSKot3TNRLf8N QLGFKORJ49VMBB0XybZhFVW+1jxN+j8OGYt8eyjrjEKS32eSGsQQ8wT2+yGNU9tOIkiF Rsmg== ARC-Authentication-Results: i=1; mx.google.com; spf=neutral (google.com: 192.134.164.83 is neither permitted nor denied by domain of julia.lawall@lip6.fr) smtp.mailfrom=julia.lawall@lip6.fr Authentication-Results: mx.google.com; spf=neutral (google.com: 192.134.164.83 is neither permitted nor denied by domain of julia.lawall@lip6.fr) smtp.mailfrom=julia.lawall@lip6.fr X-IronPort-AV: E=Sophos;i="5.49,338,1520895600"; d="scan'208";a="324881494" Date: Sat, 28 Apr 2018 09:44:48 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Sujeev Dias cc: Greg Kroah-Hartman , Arnd Bergmann , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Tony Truong , kbuild-all@01.org Subject: [PATCH] mhi_bus: core: fix debugfs_simple_attr.cocci warnings Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1598975105533234091?= X-GMAIL-MSGID: =?utf-8?q?1598975105533234091?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Fengguang Wu Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE for debugfs files. Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() imposes some significant overhead as compared to DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Fixes: ec8245f7a36f ("mhi_bus: core: Add support for MHI host interface") CC: Sujeev Dias Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- url: https://github.com/0day-ci/linux/commits/Sujeev-Dias/mhi_bus-core-Add-support-for-MHI-host-interface/20180428-065959 :::::: branch date: 3 hours ago :::::: commit date: 3 hours ago mhi_init.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- a/drivers/bus/mhi/core/mhi_init.c +++ b/drivers/bus/mhi/core/mhi_init.c @@ -233,8 +233,8 @@ static const struct file_operations debu .read = seq_read, }; -DEFINE_SIMPLE_ATTRIBUTE(debugfs_trigger_reset_fops, NULL, - mhi_debugfs_trigger_reset, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(debugfs_trigger_reset_fops, NULL, + mhi_debugfs_trigger_reset, "%llu\n"); void mhi_init_debugfs(struct mhi_controller *mhi_cntrl) { @@ -257,8 +257,8 @@ void mhi_init_debugfs(struct mhi_control debugfs_create_file("events", 0444, dentry, mhi_cntrl, &debugfs_ev_ops); debugfs_create_file("chan", 0444, dentry, mhi_cntrl, &debugfs_chan_ops); - debugfs_create_file("reset", 0444, dentry, mhi_cntrl, - &debugfs_trigger_reset_fops); + debugfs_create_file_unsafe("reset", 0444, dentry, mhi_cntrl, + &debugfs_trigger_reset_fops); mhi_cntrl->dentry = dentry; }