From: Julia Lawall <julia.lawall@lip6.fr>
To: Takashi Iwai <tiwai@suse.de>
Cc: perex@perex.cz, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: unnecessary test?
Date: Wed, 6 Jun 2018 22:06:28 +0900 (JST) [thread overview]
Message-ID: <alpine.DEB.2.20.1806062206070.4659@hadrien> (raw)
In-Reply-To: <s5h4lignk0q.wl-tiwai@suse.de>
On Wed, 6 Jun 2018, Takashi Iwai wrote:
> On Wed, 06 Jun 2018 14:39:05 +0200,
> Julia Lawall wrote:
> >
> > In the file sound/pci/ctxfi/cthw20k1.c, the function daio_mgr_dao_init
> > contains:
> >
> > set_field(&ctl->spoctl, SPOCTL_OS << (idx*8),
> > ((conf >> 3) & 0x1) ? 2 : 2); /* Raw */
> >
> > Could the second argument just be 2? It's true that the preceeding call
> > contains conf >> ..., but in a more useful way, so perhaps it could be
> > useful for uniformity?
>
> I guess this is a typo of "2 : 0". The code seems toggling the
> control bit depending on the S/PDIF passthru mode. It might be
> reversed, but I bet 1 for non-audio from a common sense.
>
> Ditto for cthw20k1.c. This one is likely 1, not 2, though.
OK, should I send a patch? I have no way to test it.
julia
>
>
> thanks,
>
> Takashi
>
next prev parent reply other threads:[~2018-06-06 13:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 12:39 Julia Lawall
2018-06-06 12:43 ` Julia Lawall
2018-06-06 13:04 ` Takashi Iwai
2018-06-06 13:06 ` Julia Lawall [this message]
2018-06-06 13:09 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1806062206070.4659@hadrien \
--to=julia.lawall@lip6.fr \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®