From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B175C3279B for ; Wed, 4 Jul 2018 10:17:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E5BCA23BFB for ; Wed, 4 Jul 2018 10:17:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5BCA23BFB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=loewensteinmedical.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934202AbeGDKR0 (ORCPT ); Wed, 4 Jul 2018 06:17:26 -0400 Received: from mail.steuer-voss.de ([85.183.69.95]:42220 "EHLO mail.steuer-voss.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932576AbeGDKRZ (ORCPT ); Wed, 4 Jul 2018 06:17:25 -0400 X-Virus-Scanned: Debian amavisd-new at mail.steuer-voss.de Received: by mail.steuer-voss.de (Postfix, from userid 1000) id C144E41B95; Wed, 4 Jul 2018 12:17:20 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.steuer-voss.de (Postfix) with ESMTP id B699441B8D; Wed, 4 Jul 2018 12:17:20 +0200 (CEST) Date: Wed, 4 Jul 2018 12:17:20 +0200 (CEST) From: Nikolaus Voss X-X-Sender: nv@fox.voss.local To: Sudeep Holla cc: Andy Shevchenko , Srinath Mannam , "Voss, Dr. Nikolaus" , "Rafael J. Wysocki" , Len Brown , Ray Jui , Vladimir Olovyannikov , Vikram Prakash , Scott Branden , ACPI Devel Maling List , Linux Kernel Mailing List , nv@vosn.de Subject: Re: [RFC PATCH] ACPI: bus: match of_device_id using acpi device In-Reply-To: <8518137d-c859-657e-844f-51720f6ef8dd@arm.com> Message-ID: References: <1530609760-8919-1-git-send-email-srinath.mannam@broadcom.com> <8518137d-c859-657e-844f-51720f6ef8dd@arm.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 Jul 2018, Sudeep Holla wrote: > On 04/07/18 10:32, Andy Shevchenko wrote: >> On Wed, Jul 4, 2018 at 6:37 AM, Srinath Mannam >> wrote: >>> Hi Sudeep, Andy, >>> >>> Yes, This patch is to get of_device_id and then fetch data pointer. >>> >>> To add ACPI support in multiple drivers which are device-tree based >>> and has list of of_device_ids, by using this function >>> very minimal changes and can avoid acpi_device_id list in the driver. >>> I will send driver changes where this function used to add ACPI >>> support in following patches. >>> >>> Below are the changes added to add ACPI support in sdhci iproc driver >>> using this function. >> >> So, did you get an ACPI ID for it? >> That's how proper ACPI support should be done. >> >> P.S. What you are trying to do is being discussed with Nikolaus in [1]. >> I have to NAK your approach in any case. Sorry. >> > > +1 on NACK for this and anything else that abuse PRP0001 as a short cut > approach. This is no abuse but exactly what PRP0001 is meant for. The basic idea of PRP0001 is to reuse DT "compatible" strings in ACPI namespace, see Documentation/acpi/enumeration.txt. Reusing also means getting access to the of_device_id. Allocating an ACPI id for an already existing DT driver is redundant, isn't it? Niko