From: Nikolaus Voss <nikolaus.voss@loewensteinmedical.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Voss, Dr. Nikolaus" <Nikolaus.Dr.Voss@loewensteinmedical.de>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Xiongfeng Wang <xiongfeng.wang@linaro.org>,
Javier Martinez Canillas <javier@dowhile0.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] IIO: st_accel_i2c.c: Simplify access to driver data
Date: Thu, 5 Jul 2018 11:30:37 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1807051129060.21087@fox.voss.local> (raw)
In-Reply-To: <CAHp75VfJOhX3+eL-ppvT7SPfDE_S7ht1drjobvFqmXPYApMETg@mail.gmail.com>
On Wed, 4 Jul 2018, Andy Shevchenko wrote:
> On Tue, Jul 3, 2018 at 8:41 AM, Nikolaus Voss
> <nikolaus.voss@loewensteinmedical.de> wrote:
>> Use device_get_match_data API to simplify access to driver data.
>> Let acpi_device_id table entries point to the same driver data as
>> of_device_id table entries and uniquify access to driver data by using
>> device_get_match_data API. Remove unused i2c_device_id .driver_data
>> fields.
>>
>
> Couple of comments below, otherwise
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
>> Signed-off-by: Nikolaus Voss <nikolaus.voss@loewensteinmedical.de>
>> ---
>> drivers/iio/accel/st_accel_i2c.c | 56 ++++++++++++++------------------
>> 1 file changed, 24 insertions(+), 32 deletions(-)
>>
>> diff --git a/drivers/iio/accel/st_accel_i2c.c b/drivers/iio/accel/st_accel_i2c.c
>> index 6bdec8c451e0..c6e08c834f11 100644
>> --- a/drivers/iio/accel/st_accel_i2c.c
>> +++ b/drivers/iio/accel/st_accel_i2c.c
>> @@ -14,8 +14,8 @@
>> #include <linux/acpi.h>
>> #include <linux/i2c.h>
>> #include <linux/iio/iio.h>
>> +#include <linux/property.h>
>>
>> -#include <linux/iio/common/st_sensors.h>
>> #include <linux/iio/common/st_sensors_i2c.h>
>> #include "st_accel.h"
>>
>> @@ -107,7 +107,7 @@ MODULE_DEVICE_TABLE(of, st_accel_of_match);
>>
>> #ifdef CONFIG_ACPI
>> static const struct acpi_device_id st_accel_acpi_match[] = {
>> - {"SMO8A90", LNG2DM},
>> + {"SMO8A90", (kernel_ulong_t)LNG2DM_ACCEL_DEV_NAME},
>> { },
>
> Is it done against iio-next?
>
> I see two records in this table.
No, I'll rebase onto linux-next and resend...
Niko
...
next prev parent reply other threads:[~2018-07-05 9:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 13:27 [PATCH v3 0/2] IIO: st_sensors_i2c: improve device enumeration Nikolaus Voss
2018-07-03 5:41 ` [PATCH v3 1/2] IIO: st_accel_i2c.c: Simplify access to driver data Nikolaus Voss
2018-07-04 16:10 ` Andy Shevchenko
2018-07-05 9:30 ` Nikolaus Voss [this message]
2018-07-03 6:06 ` [PATCH v3 2/2] IIO: st_accel_i2c.c: Use probe_new() instead of probe() Nikolaus Voss
2018-07-04 16:15 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1807051129060.21087@fox.voss.local \
--to=nikolaus.voss@loewensteinmedical.de \
--cc=Nikolaus.Dr.Voss@loewensteinmedical.de \
--cc=andy.shevchenko@gmail.com \
--cc=javier@dowhile0.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=xiongfeng.wang@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®