From: Julia Lawall <julia.lawall@lip6.fr>
To: Sohil Ladhani <supertakumi86@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
Kees Cook <keescook@chromium.org>,
Julia Lawall <julia.lawall@lip6.fr>,
Nathan Chancellor <natechancellor@gmail.com>,
Ping-Ke Shih <pkshih@realtek.com>,
Arushi Singhal <arushisinghal19971997@gmail.com>,
"Frank A. Cancio Bello" <frank@generalsoftwareinc.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtlwifi: base: fixed a brace coding style issue
Date: Sat, 4 Aug 2018 09:08:46 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1808040907480.2435@hadrien> (raw)
In-Reply-To: <20180804070540.GA8867@zenus>
On Sat, 4 Aug 2018, Sohil Ladhani wrote:
> Fixed a coding style issue
This seems to fix the header problem. But it is a patch on the same code
at the same place doing the same thing as the previous message. So you
should say [PATCH v2] in the subject line, and then below the --- explain
what has changed as compared to the previous submission.
julia
>
> Signed-off-by: Sohil Ladhani <supertakumi86@gmail.com>
> ---
> drivers/staging/rtlwifi/base.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtlwifi/base.c b/drivers/staging/rtlwifi/base.c
> index 094827c1879a..654aa4e068ba 100644
> --- a/drivers/staging/rtlwifi/base.c
> +++ b/drivers/staging/rtlwifi/base.c
> @@ -685,9 +685,8 @@ static void _rtl_query_protection_mode(struct ieee80211_hw *hw,
> }
> }
>
> -u8 rtl_mrate_idx_to_arfr_id(
> - struct ieee80211_hw *hw, u8 rate_index,
> - enum wireless_mode wirelessmode)
> +u8 rtl_mrate_idx_to_arfr_id(struct ieee80211_hw *hw, u8 rate_index,
> + enum wireless_mode wirelessmode)
> {
> struct rtl_priv *rtlpriv = rtl_priv(hw);
> struct rtl_phy *rtlphy = &rtlpriv->phy;
> --
> 2.18.0
>
>
prev parent reply other threads:[~2018-08-04 7:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-04 7:05 Sohil Ladhani
2018-08-04 7:08 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1808040907480.2435@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Larry.Finger@lwfinger.net \
--cc=arushisinghal19971997@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=frank@generalsoftwareinc.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=pkshih@realtek.com \
--cc=supertakumi86@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®