From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20475C46464 for ; Tue, 14 Aug 2018 14:10:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C31E22172D for ; Tue, 14 Aug 2018 14:10:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C31E22172D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lip6.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732150AbeHNQ55 (ORCPT ); Tue, 14 Aug 2018 12:57:57 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:20461 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728978AbeHNQ55 (ORCPT ); Tue, 14 Aug 2018 12:57:57 -0400 X-IronPort-AV: E=Sophos;i="5.53,238,1531778400"; d="scan'208";a="275831430" Received: from vaio-julia.rsr.lip6.fr ([132.227.76.33]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Aug 2018 16:10:35 +0200 Date: Tue, 14 Aug 2018 16:10:26 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Mark Brown cc: Julia Lawall , Wu Zhigang , kbuild-all@01.org, sof-ci-monitor@eclists.intel.com, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Ranjani Sridharan , Rander Wang , Pan Xiuli , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fix ifnullfree.cocci warnings In-Reply-To: <20180814140344.GB5810@sirena.org.uk> Message-ID: References: <20180814140344.GB5810@sirena.org.uk> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Aug 2018, Mark Brown wrote: > On Tue, Aug 14, 2018 at 12:57:57PM +0200, Julia Lawall wrote: > > From: kbuild test robot > > > > NULL check before some freeing functions is not needed. > > > > Based on checkpatch warning > > "kfree(NULL) is safe this check is probably not required" > > and kfreeaddr.cocci by Julia Lawall. > > > > Generated by: scripts/coccinelle/free/ifnullfree.cocci > > > > Fixes: 0099cc17a399 ("ASoC:topology:avoid error log and oops during topology free.") > > This doesn't apply against current code, please check and resend (the > above commit isn't in my tree: > > $ git show 0099cc17a399 > fatal: ambiguous argument '0099cc17a399': unknown revision or path not in the working tree. Sorry, I didn't keep the tree information. julia