From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D098FC43381 for ; Wed, 20 Feb 2019 12:56:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A41B820C01 for ; Wed, 20 Feb 2019 12:56:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727889AbfBTM4q (ORCPT ); Wed, 20 Feb 2019 07:56:46 -0500 Received: from mail.steuer-voss.de ([85.183.69.95]:59798 "EHLO mail.steuer-voss.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726172AbfBTM4q (ORCPT ); Wed, 20 Feb 2019 07:56:46 -0500 X-Virus-Scanned: Debian amavisd-new at mail.steuer-voss.de Received: by mail.steuer-voss.de (Postfix, from userid 1000) id 2C1074CFAB; Wed, 20 Feb 2019 13:56:43 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail.steuer-voss.de (Postfix) with ESMTP id 2A2C94CFA6; Wed, 20 Feb 2019 13:56:43 +0100 (CET) Date: Wed, 20 Feb 2019 13:56:43 +0100 (CET) From: Nikolaus Voss X-X-Sender: nv@fox.voss.local To: Heikki Krogerus cc: Greg Kroah-Hartman , Guenter Roeck , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters In-Reply-To: <20190220121441.GA5054@kuha.fi.intel.com> Message-ID: References: <20180425142209.30745-1-heikki.krogerus@linux.intel.com> <20190220110017.BFA344CE86@mail.steuer-voss.de> <20190220121441.GA5054@kuha.fi.intel.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, 20 Feb 2019, Heikki Krogerus wrote: > Hi, > > On Mon, Sep 10, 2018 at 07:05:01AM +0200, Nikolaus Voss wrote: >> Commit 1a2f474d328f handles block _reads_ separately with plain-I2C >> adapters, but the problem described with regmap-i2c not handling >> SMBus block transfers (i.e. read and writes) correctly also exists >> with writes. >> >> As workaround, this patch adds a block write function the same way >> 1a2f474d328f adds a block read function. >> >> Fixes: 1a2f474d328f ("usb: typec: tps6598x: handle block reads separately with plain-I2C adapters") >> Fixes: 0a4c005bd171 ("usb: typec: driver for TI TPS6598x USB Power Delivery controllers") >> Signed-off-by: Nikolaus Voss >> --- >> drivers/usb/typec/tps6598x.c | 22 ++++++++++++++++++---- >> 1 file changed, 18 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/usb/typec/tps6598x.c b/drivers/usb/typec/tps6598x.c >> index c84c8c189e90..57a3e6c5c175 100644 >> --- a/drivers/usb/typec/tps6598x.c >> +++ b/drivers/usb/typec/tps6598x.c >> @@ -110,6 +110,20 @@ tps6598x_block_read(struct tps6598x *tps, u8 reg, void *val, size_t len) >> return 0; >> } >> >> +static int tps6598x_block_write(struct tps6598x *tps, u8 reg, >> + void *val, size_t len) >> +{ >> + u8 data[len + 1]; >> + >> + if (!tps->i2c_protocol) >> + return regmap_raw_write(tps->regmap, reg, val, len); >> + >> + data[0] = len; >> + memcpy(&data[1], val, len); >> + >> + return regmap_raw_write(tps->regmap, reg, data, sizeof(data)); >> +} >> + >> static inline int tps6598x_read16(struct tps6598x *tps, u8 reg, u16 *val) >> { >> return tps6598x_block_read(tps, reg, val, sizeof(u16)); >> @@ -127,23 +141,23 @@ static inline int tps6598x_read64(struct tps6598x *tps, u8 reg, u64 *val) >> >> static inline int tps6598x_write16(struct tps6598x *tps, u8 reg, u16 val) >> { >> - return regmap_raw_write(tps->regmap, reg, &val, sizeof(u16)); >> + return tps6598x_block_write(tps, reg, &val, sizeof(u16)); >> } >> >> static inline int tps6598x_write32(struct tps6598x *tps, u8 reg, u32 val) >> { >> - return regmap_raw_write(tps->regmap, reg, &val, sizeof(u32)); >> + return tps6598x_block_write(tps, reg, &val, sizeof(u32)); >> } >> >> static inline int tps6598x_write64(struct tps6598x *tps, u8 reg, u64 val) >> { >> - return regmap_raw_write(tps->regmap, reg, &val, sizeof(u64)); >> + return tps6598x_block_write(tps, reg, &val, sizeof(u64)); >> } >> >> static inline int >> tps6598x_write_4cc(struct tps6598x *tps, u8 reg, const char *val) >> { >> - return regmap_raw_write(tps->regmap, reg, &val, sizeof(u32)); >> + return tps6598x_block_write(tps, reg, &val, sizeof(u32)); >> } >> >> static int tps6598x_read_partner_identity(struct tps6598x *tps) > > You need to fix tps6598x_exec_cmd() as well. Right, thanks. I will fix that. > > Did you really send this last September? If you did, then the mail has > been stuck somewhere for a long time. It's been stuck with me, I forgot to send it ;-). Nikolaus