From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D223DC43381 for ; Wed, 20 Feb 2019 15:08:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AEE8120859 for ; Wed, 20 Feb 2019 15:08:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727014AbfBTPIf (ORCPT ); Wed, 20 Feb 2019 10:08:35 -0500 Received: from mail.steuer-voss.de ([85.183.69.95]:33988 "EHLO mail.steuer-voss.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725842AbfBTPIe (ORCPT ); Wed, 20 Feb 2019 10:08:34 -0500 X-Virus-Scanned: Debian amavisd-new at mail.steuer-voss.de Received: by mail.steuer-voss.de (Postfix, from userid 1000) id 8FC4E4D133; Wed, 20 Feb 2019 16:08:31 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail.steuer-voss.de (Postfix) with ESMTP id 8B8234D132; Wed, 20 Feb 2019 16:08:31 +0100 (CET) Date: Wed, 20 Feb 2019 16:08:31 +0100 (CET) From: Nikolaus Voss X-X-Sender: nv@fox.voss.local To: Heikki Krogerus cc: Greg Kroah-Hartman , Guenter Roeck , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters In-Reply-To: <20190220143053.GD5054@kuha.fi.intel.com> Message-ID: References: <20180425142209.30745-1-heikki.krogerus@linux.intel.com> <20190220110017.BFA344CE86@mail.steuer-voss.de> <20190220125731.02E274CFE0@mail.steuer-voss.de> <20190220133036.GB5054@kuha.fi.intel.com> <20190220141423.GC5054@kuha.fi.intel.com> <20190220143053.GD5054@kuha.fi.intel.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 20 Feb 2019, Heikki Krogerus wrote: > On Wed, Feb 20, 2019 at 04:14:23PM +0200, Heikki Krogerus wrote: >> On Wed, Feb 20, 2019 at 02:38:47PM +0100, Nikolaus Voss wrote: >>> On Wed, 20 Feb 2019, Heikki Krogerus wrote: >>>> On Wed, Feb 20, 2019 at 01:57:30PM +0100, Nikolaus Voss wrote: >>>>> Commit 1a2f474d328f handles block _reads_ separately with plain-I2C >>>>> adapters, but the problem described with regmap-i2c not handling >>>>> SMBus block transfers (i.e. read and writes) correctly also exists >>>>> with writes. >>>>> >>>>> As workaround, this patch adds a block write function the same way >>>>> 1a2f474d328f adds a block read function. >>>>> >>>>> Fixes: 1a2f474d328f ("usb: typec: tps6598x: handle block reads separately with plain-I2C adapters") >>>>> Fixes: 0a4c005bd171 ("usb: typec: driver for TI TPS6598x USB Power Delivery controllers") >>>>> Signed-off-by: Nikolaus Voss >>>> >>>> You are missing a "from" line with address that matches your SoB >>>> address. >>> >>> That's because I currently cannot send patch mails from my company account >>> as our MTA breaks diffs. >> >> I understand, but you can have a separate "From line" in your patch, >> i.e. you send the patch using one address, and have an extra "From >> line" (outside of the mail header) with another address. >> >> That other From line will be interpreted as the author address, and >> it should match your SoB address. >> >> >> Try something like this in a branch where this patch is the HEAD: >> >> % export MY_COMMIT=$(git show -s --pretty=%h HEAD) >> % git reset HEAD^ >> % GIT_COMMITTER_IDENT='Nikolaus Voss ' \ >> GIT_AUTHOR_IDENT='Nikolaus Voss ' \ >> git commit -a -C $MY_COMMIT > > Correction here: > > % GIT_COMMITTER_IDENT='Nikolaus Voss ' \ > GIT_AUTHOR_IDENT='Nikolaus Voss ' \ > git commit -a -C $MY_COMMIT --reset-author > > That "--reset-author" was missing. Sorry for that. Thanks, Heikki, I'll give it a try... Nikolaus