From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2B7AC04AB1 for ; Mon, 13 May 2019 09:32:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79ADE20989 for ; Mon, 13 May 2019 09:32:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728449AbfEMJcu (ORCPT ); Mon, 13 May 2019 05:32:50 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:2950 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726218AbfEMJcu (ORCPT ); Mon, 13 May 2019 05:32:50 -0400 X-IronPort-AV: E=Sophos;i="5.60,465,1549926000"; d="scan'208";a="382867874" Received: from vaio-julia.rsr.lip6.fr ([132.227.76.33]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 May 2019 11:32:48 +0200 Date: Mon, 13 May 2019 11:32:45 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Markus Elfring cc: Julia Lawall , Gilles Muller , Masahiro Yamada , Michal Marek , Nicolas Palix , Wen Yang , cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org, Yi Wang Subject: Re: [PATCH 3/5] Coccinelle: put_device: Merge four SmPL when constraints into one In-Reply-To: <6b62ecb5-ab88-22d9-eee2-db4f58b6d2ae@web.de> Message-ID: References: <1553321671-27749-1-git-send-email-wen.yang99@zte.com.cn> <6b62ecb5-ab88-22d9-eee2-db4f58b6d2ae@web.de> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 May 2019, Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 12 May 2019 18:32:46 +0200 > > An assignment target was repeated in four SmPL when constraints. > Combine the exclusion specifications into disjunctions for the semantic > patch language so that this target is referenced only once there. NACK. This exceeds 80 characters and provides no readability benefit. julia > > Signed-off-by: Markus Elfring > --- > scripts/coccinelle/free/put_device.cocci | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/scripts/coccinelle/free/put_device.cocci b/scripts/coccinelle/free/put_device.cocci > index 120921366e84..aae79c02c1e0 100644 > --- a/scripts/coccinelle/free/put_device.cocci > +++ b/scripts/coccinelle/free/put_device.cocci > @@ -23,10 +23,7 @@ if (id == NULL || ...) { ... return ...; } > when != platform_device_put(id) > when != of_dev_put(id) > when != if (id) { ... put_device(&id->dev) ... } > - when != e1 = (T)id > - when != e1 = (T)(&id->dev) > - when != e1 = get_device(&id->dev) > - when != e1 = (T1)platform_get_drvdata(id) > + when != e1 = \( (T) \( id \| (&id->dev) \) \| get_device(&id->dev) \| (T1)platform_get_drvdata(id) \) > ( > return > ( id > -- > 2.21.0 > >