From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF012C04AB1 for ; Mon, 13 May 2019 09:35:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C2BC720873 for ; Mon, 13 May 2019 09:35:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728571AbfEMJfs (ORCPT ); Mon, 13 May 2019 05:35:48 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:3260 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726103AbfEMJfq (ORCPT ); Mon, 13 May 2019 05:35:46 -0400 X-IronPort-AV: E=Sophos;i="5.60,465,1549926000"; d="scan'208";a="382868419" Received: from vaio-julia.rsr.lip6.fr ([132.227.76.33]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 May 2019 11:35:44 +0200 Date: Mon, 13 May 2019 11:35:40 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Markus Elfring cc: Gilles Muller , Masahiro Yamada , Michal Marek , Nicolas Palix , Wen Yang , cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org, Yi Wang Subject: Re: [PATCH 1/5] Coccinelle: put_device: Adjust a message construction In-Reply-To: <308f5571-68f3-7505-d5ad-59ee68091959@web.de> Message-ID: References: <1553321671-27749-1-git-send-email-wen.yang99@zte.com.cn> <308f5571-68f3-7505-d5ad-59ee68091959@web.de> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 May 2019, Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 7 May 2019 11:20:48 +0200 > > The Linux coding style tolerates long string literals so that > the provided information can be easier found also by search tools > like grep. > Thus simplify a message construction in a SmPL rule by concatenating text > with two plus operators less. I don't know python very well. Is there any way to unindent, so that the string doesn't exceed 80 characters, or at least no so much? On the other hand, I would have much preferred the original msg = code. I don't understand why it is so offensive. julia > > Signed-off-by: Markus Elfring > --- > scripts/coccinelle/free/put_device.cocci | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/scripts/coccinelle/free/put_device.cocci b/scripts/coccinelle/free/put_device.cocci > index c9f071b0a0ab..3ebebc064f10 100644 > --- a/scripts/coccinelle/free/put_device.cocci > +++ b/scripts/coccinelle/free/put_device.cocci > @@ -42,11 +42,10 @@ p1 << search.p1; > p2 << search.p2; > @@ > > -coccilib.report.print_report(p2[0], "ERROR: missing put_device; " > - + "call of_find_device_by_node on line " > - + p1[0].line > - + ", but without a corresponding object release " > - + "within this function.") > +coccilib.report.print_report(p2[0], > + "ERROR: missing put_device; call of_find_device_by_node on line " > + + p1[0].line > + + ", but without a corresponding object release within this function.") > > @script:python depends on org@ > p1 << search.p1; > -- > 2.21.0 > >