From: Nikolaus Voss <nv@vosn.de>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Andreas Dannenberg <dannenberg@ti.com>,
"Andrew F. Davis" <afd@ti.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH] sound/soc/codecs/tas5720.c: add ACPI support
Date: Mon, 1 Jul 2019 10:55:59 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1907011055090.2390@fox.voss.local> (raw)
In-Reply-To: <20190628143037.GH5379@sirena.org.uk>
On Fri, 28 Jun 2019, Mark Brown wrote:
> On Fri, Jun 28, 2019 at 02:34:16PM +0200, Nikolaus Voss wrote:
>> Add support for ACPI enumeration for tas5720 and tas5722.
>> Use device_match API to unify access to driver data for DT and ACPI.
>> Aggregate variant stuff into its own struct and directly reference
>> it in variant data for i2c/of/acpi_device_id.
>
> Please use subject lines matching the style for the subsystem. This
> makes it easier for people to identify relevant patches.
>
> There's a huge amount of refactoring in here as well as the enumeration
> changes, please split this up into a patch series as covered in
> submitting-patches.rst for review.
>
Ok, thanks for the feedback, I'll prepare a series.
Nikolaus
next prev parent reply other threads:[~2019-07-01 8:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 12:34 Nikolaus Voss
2019-06-28 14:30 ` Mark Brown
2019-07-01 8:55 ` Nikolaus Voss [this message]
2019-07-01 13:42 ` [PATCH v2 0/2] ASoC: tas5720.c: add ACPI enumeration support Nikolaus Voss
2019-07-01 13:42 ` [PATCH v2 1/2] ASoC: tas5720.c: cleanup variant management Nikolaus Voss
2019-07-01 14:25 ` Andrew F. Davis
2019-07-01 15:35 ` Nikolaus Voss
2019-07-01 16:09 ` Andrew F. Davis
2019-07-02 10:12 ` Nikolaus Voss
2019-07-03 19:24 ` Andrew F. Davis
2019-07-04 5:36 ` Nikolaus Voss
2019-07-01 13:42 ` [PATCH v2 2/2] ASoC: tas5720.c: add ACPI enumeration support Nikolaus Voss
2019-06-28 14:50 ` [PATCH] sound/soc/codecs/tas5720.c: add ACPI support Andrew F. Davis
2019-07-01 8:56 ` Nikolaus Voss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1907011055090.2390@fox.voss.local \
--to=nv@vosn.de \
--cc=afd@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dannenberg@ti.com \
--cc=kstewart@linuxfoundation.org \
--cc=lgirdwood@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®