From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10D10C3A5A4 for ; Sun, 25 Aug 2019 17:52:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DED28217F4 for ; Sun, 25 Aug 2019 17:52:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728767AbfHYRwZ (ORCPT ); Sun, 25 Aug 2019 13:52:25 -0400 Received: from cnc.isely.net ([75.149.91.89]:46025 "EHLO cnc.isely.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727835AbfHYRwY (ORCPT ); Sun, 25 Aug 2019 13:52:24 -0400 X-Greylist: delayed 303 seconds by postgrey-1.27 at vger.kernel.org; Sun, 25 Aug 2019 13:52:24 EDT Received: from lochley (lochley-lan.isely.net [::ffff:192.168.23.74]) (AUTH: PLAIN isely, TLS: TLSv1/SSLv3,256bits,DHE-RSA-AES256-GCM-SHA384) by cnc.isely.net with ESMTPSA; Sun, 25 Aug 2019 12:47:20 -0500 id 000000000014205E.000000005D62C9A8.00004CB9 Date: Sun, 25 Aug 2019 12:47:20 -0500 (CDT) From: isely@isely.net To: Yizhuo cc: csong@cs.ucr.edu, zhiyunq@cs.ucr.edu, Mauro Carvalho Chehab , linux-media@vger.kernel.org, Linux Kernel Mailing List , Mike Isely at pobox Subject: Re: [PATCH] [media] pvrusb2: qctrl.flag will be uninitlaized if cx2341x_ctrl_query() returns error code In-Reply-To: <20190821210931.9621-1-yzhai003@ucr.edu> Message-ID: References: <20190821210931.9621-1-yzhai003@ucr.edu> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Acked-by: Mike Isely On Wed, 21 Aug 2019, Yizhuo wrote: > Inside function ctrl_cx2341x_getv4lflags(), qctrl.flag > will be uninitlaized if cx2341x_ctrl_query() returns -EINVAL. > However, it will be used in the later if statement, which is > potentially unsafe. > > Signed-off-by: Yizhuo > --- > drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c > index ad5b25b89699..1fa05971316a 100644 > --- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c > +++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c > @@ -793,6 +793,7 @@ static unsigned int ctrl_cx2341x_getv4lflags(struct pvr2_ctrl *cptr) > struct v4l2_queryctrl qctrl; > struct pvr2_ctl_info *info; > qctrl.id = cptr->info->v4l_id; > + memset(&qctr, 0, sizeof(qctrl)) > cx2341x_ctrl_query(&cptr->hdw->enc_ctl_state,&qctrl); > /* Strip out the const so we can adjust a function pointer. It's > OK to do this here because we know this is a dynamically created > -- Mike Isely isely @ isely (dot) net PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8