From: "Maciej W. Rozycki" <macro@embecosm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] tty: Partially revert the removal of the Cyclades public API
Date: Wed, 26 Jan 2022 09:22:31 +0000 (GMT) [thread overview]
Message-ID: <alpine.DEB.2.20.2201260542450.11348@tpp.orcam.me.uk> (raw)
In-Reply-To: <Ye5vx/8CYH2zWK28@infradead.org>
On Mon, 24 Jan 2022, Christoph Hellwig wrote:
> > Fix a user API regression introduced with commit f76edd8f7ce0 ("tty:
> > cyclades, remove this orphan"), which removed a part of the API and
> > caused compilation errors for user programs using said part, such as
> > GCC 9 in its libsanitizer component[1]:
>
> This looks sensible, but a #warning might be useful to get people to
> stop including this random header.
We have no precedent, but your suggestion seems reasonable to me, thanks.
Maciej
prev parent reply other threads:[~2022-01-26 9:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 13:32 Maciej W. Rozycki
2022-01-24 9:22 ` Christoph Hellwig
2022-01-26 9:22 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.2201260542450.11348@tpp.orcam.me.uk \
--to=macro@embecosm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®