From: Thomas Gleixner <tglx@linutronix.de>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: David Miller <davem@davemloft.net>,
edumazet@google.com, torvalds@linux-foundation.org,
efault@gmx.de, peterz@infradead.org, dima@arista.com,
frederic@kernel.org, linux-kernel@vger.kernel.org,
0x7f454c46@gmail.com, akpm@linux-foundation.org,
fweisbec@gmail.com, hannes@stressinduktion.org, mingo@kernel.org,
alexander.levin@verizon.com, pabeni@redhat.com,
paulmck@linux.vnet.ibm.com, rrendec@arista.com, riel@redhat.com,
sgruszka@redhat.com, wanpeng.li@hotmail.com
Subject: Re: [RFC 1/2] softirq: Defer net rx/tx processing to ksoftirqd context
Date: Tue, 13 Feb 2018 17:36:34 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1802131735460.1130@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20180206165649.cze4iy4k36rcigbe@breakpoint.cc>
On Tue, 6 Feb 2018, Sebastian Andrzej Siewior wrote:
> On 2018-01-17 17:24:47 [-0500], David Miller wrote:
> > From: Eric Dumazet <edumazet@google.com>
> > Date: Wed, 17 Jan 2018 14:02:43 -0800
> > > There is also the netif_rx_ni() stuff.
> > >
> > > Can't remember right now why it is not using
> > > local_bh_{diable,enable}() pair instead
> > > of preempt_disable() ... if (local_softirq_pending()) do_softirq();
> >
> > Hmmm, that code predates the initial GIT repository build.
> >
> > I do remember we had some back and forth with that stuff.
>
> So I did a little research and tried to replace preempt_disable() with
> local_bh_disable() [0] a while ago.
>
> [0] https://lkml.kernel.org/r/20170616172400.10809-1-bigeasy@linutronix.de
Maybe you should just try again with a slightly better changelog :)
next prev parent reply other threads:[~2018-02-13 16:36 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 13:36 [RFC 0/2] Net softirq deferring to ksoftirqd Dmitry Safonov
2018-01-09 13:36 ` [RFC 1/2] softirq: Defer net rx/tx processing to ksoftirqd context Dmitry Safonov
2018-01-09 16:03 ` Frederic Weisbecker
2018-01-10 21:20 ` Dmitry Safonov
2018-01-09 18:02 ` Eric Dumazet
2018-01-10 21:48 ` Dmitry Safonov
2018-01-11 2:13 ` Linus Torvalds
2018-01-11 3:22 ` Frederic Weisbecker
2018-01-11 4:19 ` Linus Torvalds
2018-01-11 4:44 ` Frederic Weisbecker
2018-01-11 14:31 ` Dmitry Safonov
2018-01-11 16:20 ` Eric Dumazet
2018-01-11 16:32 ` Peter Zijlstra
2018-01-11 16:38 ` David Miller
2018-01-11 16:43 ` Peter Zijlstra
2018-01-11 18:48 ` Linus Torvalds
2018-01-11 19:15 ` Eric Dumazet
2018-01-11 19:43 ` Linus Torvalds
2018-01-11 19:48 ` Eric Dumazet
2018-01-11 20:03 ` Linus Torvalds
2018-01-11 20:16 ` Eric Dumazet
2018-01-11 20:22 ` Linus Torvalds
2018-01-11 20:34 ` Dmitry Safonov
2018-01-11 20:37 ` Eric Dumazet
2018-01-11 20:40 ` Linus Torvalds
2018-01-11 20:46 ` Dmitry Safonov
2018-01-11 20:53 ` Eric Dumazet
2018-01-11 21:13 ` Dmitry Safonov
2018-01-12 5:41 ` Frederic Weisbecker
2018-01-12 5:23 ` Mike Galbraith
2018-01-12 10:13 ` Peter Zijlstra
2018-01-12 17:26 ` Linus Torvalds
2018-01-12 17:44 ` Mike Galbraith
2018-01-12 17:51 ` Linus Torvalds
2018-01-12 18:15 ` Mike Galbraith
2018-01-12 18:44 ` Mike Galbraith
2018-01-17 20:30 ` David Miller
2018-01-17 21:06 ` Linus Torvalds
2018-01-17 21:49 ` David Miller
2018-01-17 21:54 ` Thomas Gleixner
2018-01-17 21:58 ` Linus Torvalds
2018-01-17 22:00 ` Thomas Gleixner
2018-01-17 22:02 ` Eric Dumazet
2018-01-17 22:24 ` David Miller
2018-01-17 22:54 ` Thomas Gleixner
2018-02-06 16:56 ` Sebastian Andrzej Siewior
2018-02-13 16:36 ` Thomas Gleixner [this message]
2018-01-17 21:54 ` Linus Torvalds
2018-01-17 21:58 ` Thomas Gleixner
2018-01-12 19:28 ` Thomas Gleixner
2018-01-12 19:53 ` Frederic Weisbecker
2018-01-12 14:58 ` Frederic Weisbecker
2018-01-12 15:15 ` Mike Galbraith
2018-01-12 17:00 ` Frederic Weisbecker
2018-01-12 18:08 ` Mike Galbraith
2018-01-12 17:24 ` Linus Torvalds
2018-01-09 13:36 ` [RFC 2/2] softirq: Introduce mask for __do_softirq() Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1802131735460.1130@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=0x7f454c46@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.levin@verizon.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=dima@arista.com \
--cc=edumazet@google.com \
--cc=efault@gmx.de \
--cc=frederic@kernel.org \
--cc=fweisbec@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pabeni@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=rrendec@arista.com \
--cc=sgruszka@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=wanpeng.li@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®