From: Thomas Gleixner <tglx@linutronix.de>
To: Lina Iyer <ilina@codeaurora.org>
Cc: jason@lakedaemon.net, marc.zyngier@arm.com,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
rnayak@codeaurora.org, asathyak@codeaurora.org
Subject: Re: [PATCH v6 1/2] drivers: irqchip: pdc: Add PDC interrupt controller for QCOM SoCs
Date: Thu, 15 Feb 2018 21:24:56 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1802152122480.1296@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20180215202141.GC23714@codeaurora.org>
On Thu, 15 Feb 2018, Lina Iyer wrote:
> On Mon, Feb 12 2018 at 13:40 +0000, Thomas Gleixner wrote:
> > On Fri, 9 Feb 2018, Lina Iyer wrote:
> > > +enum pdc_irq_config_bits {
> > > + PDC_POLARITY_LOW = 0,
> > > + PDC_FALLING_EDGE = 2,
> > > + PDC_POLARITY_HIGH = 4,
> > > + PDC_RISING_EDGE = 6,
> > > + PDC_DUAL_EDGE = 7,
> >
> > My previous comment about using binary constants still stands. Please
> > either address review comments or reply at least. Ignoring reviews is not
> > an option.
> >
> > Aside of that I really have to ask about the naming of these constants. Are
> > these names hardware register nomenclature? If yes, they are disgusting. If
> > no, they are still disgusting, but should be changed to sensible ones,
> > which just match the IRQ_TYPE naming convention.
> >
> > PDC_LEVEL_LOW = 000b,
> > PDC_EDGE_FALLING = 010b,
> > ....
> >
> >
> Checkpatch doesn't like binary constants. I guess I will need to keep
> the enum definitions in hex or decimal. I will remove the binary from
> the comments though.
Well checkpatch is not always right.
>
> commit 95e2c6023b0e4c8499fb521697f79215f69135fe
> Author: Joe Perches <joe@perches.com>
> Date: Wed Jul 3 15:05:20 2013 -0700
>
> checkpatch: warn when using gcc's binary constant ("0b") extension
>
> The gcc extension for binary constants that start with 0b is only
> supported with gcc version 4.3 or higher.
Can anything of this be compiled with gcc < 4.3?
Thanks,
tglx
next prev parent reply other threads:[~2018-02-15 20:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 16:57 [PATCH v6 0/2] irqchip: qcom: add support for PDC interrupt controller Lina Iyer
2018-02-09 16:57 ` [PATCH v6 1/2] drivers: irqchip: pdc: Add PDC interrupt controller for QCOM SoCs Lina Iyer
2018-02-12 13:40 ` Thomas Gleixner
2018-02-12 16:01 ` Lina Iyer
2018-02-15 20:21 ` Lina Iyer
2018-02-15 20:24 ` Thomas Gleixner [this message]
2018-02-15 20:31 ` Lina Iyer
2018-02-09 16:57 ` [PATCH v6 2/2] dt-bindings/interrupt-controller: pdc: descibe PDC device binding Lina Iyer
2018-02-18 23:51 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1802152122480.1296@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=asathyak@codeaurora.org \
--cc=ilina@codeaurora.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=rnayak@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®