From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CDDAECDE5F for ; Thu, 19 Jul 2018 06:26:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4EB4220854 for ; Thu, 19 Jul 2018 06:26:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EB4220854 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731269AbeGSHHl (ORCPT ); Thu, 19 Jul 2018 03:07:41 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:60210 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726303AbeGSHHl (ORCPT ); Thu, 19 Jul 2018 03:07:41 -0400 Received: from p4fea5a5a.dip0.t-ipconnect.de ([79.234.90.90] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1fg2NT-0001oZ-Dc; Thu, 19 Jul 2018 08:25:27 +0200 Date: Thu, 19 Jul 2018 08:25:26 +0200 (CEST) From: Thomas Gleixner To: Dou Liyang cc: Pavel Tatashin , steven.sistare@oracle.com, daniel.m.jordan@oracle.com, linux@armlinux.org.uk, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, john.stultz@linaro.org, sboyd@codeaurora.org, x86@kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com, peterz@infradead.org, prarit@redhat.com, feng.tang@intel.com, pmladek@suse.com, gnomes@lxorguk.ukuu.org.uk, linux-s390@vger.kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com, pbonzini@redhat.com Subject: Re: [PATCH v14 20/25] x86/tsc: calibrate tsc only once In-Reply-To: <4f0933a3-27b4-5468-83f5-af9b90842812@cn.fujitsu.com> Message-ID: References: <20180718022211.6259-1-pasha.tatashin@oracle.com> <20180718022211.6259-21-pasha.tatashin@oracle.com> <4f0933a3-27b4-5468-83f5-af9b90842812@cn.fujitsu.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 19 Jul 2018, Dou Liyang wrote: > At 07/18/2018 10:22 AM, Pavel Tatashin wrote: > > + (unsigned long)cpu_khz % KHZ); > > if (cpu_khz != tsc_khz) { > > pr_info("Detected %lu.%03lu MHz TSC", > > - (unsigned long)tsc_khz / 1000, > > - (unsigned long)tsc_khz % 1000); > > + (unsigned long)tsc_khz / KHZ, > > + (unsigned long)tsc_khz % KHZ); > > + } > > this curly brackets can be removed No. They want to stay, really. https://lkml.kernel.org/r/alpine.DEB.2.20.1701171956290.3645@nanos The pr_info() is a multiline statement due to the line breaks. Thanks, tglx