mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Alistair Strachan <astrachan@google.com>
Cc: linux-kernel@vger.kernel.org, Andy Lutomirski <luto@kernel.org>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	x86@kernel.org, kernel-team@android.com, joel@joelfernandes.com
Subject: Re: [PATCH] x86: vdso: Use $LD instead of $CC to link
Date: Fri, 3 Aug 2018 12:26:23 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1808031223500.1745@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20180718224159.18236-1-astrachan@google.com>

On Wed, 18 Jul 2018, Alistair Strachan wrote:
>  export CPPFLAGS_vdso.lds += -P -C
>  
> -VDSO_LDFLAGS_vdso.lds = -m64 -Wl,-soname=linux-vdso.so.1 \
> -			-Wl,--no-undefined \
> -			-Wl,-z,max-page-size=4096 -Wl,-z,common-page-size=4096 \
> -			$(DISABLE_LTO)
> +VDSO_LDFLAGS_vdso.lds = -m elf_x86_64 -soname linux-vdso.so.1 --no-undefined \
> +			-z max-page-size=4096 -z common-page-size=4096

Aside of the fact that it does not apply to upstream, why is this dropping
the $(DISABLE_LTO) part?

The changelog is utterly silent about that.

Thanks,

	tglx

  parent reply	other threads:[~2018-08-03 10:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-18 22:41 Alistair Strachan
2018-07-21 23:28 ` Andy Lutomirski
2018-08-03 10:26 ` Thomas Gleixner [this message]
2018-08-03 17:29   ` Alistair Strachan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1808031223500.1745@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=astrachan@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=joel@joelfernandes.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®