mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
	x86@kernel.org, Al Stone <astone@redhat.com>,
	Borislav Petkov <bp@alien8.de>, Ingo Molnar <mingo@kernel.org>,
	Andy Lutomirski <luto@kernel.org>,
	Bhupesh Sharma <bhsharma@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH V6 2/2] x86/efi: Add efi page fault handler to recover from page faults caused by the firmware
Date: Wed, 12 Sep 2018 20:56:20 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1809122055190.1473@nanos.tec.linutronix.de> (raw)
In-Reply-To: <1536693322-8335-3-git-send-email-sai.praneeth.prakhya@intel.com>

On Tue, 11 Sep 2018, Sai Praneeth Prakhya wrote:
> diff --git a/drivers/firmware/efi/runtime-wrappers.c b/drivers/firmware/efi/runtime-wrappers.c
> index b18b2d864c2c..7455277a3b65 100644
> --- a/drivers/firmware/efi/runtime-wrappers.c
> +++ b/drivers/firmware/efi/runtime-wrappers.c
> @@ -61,6 +61,11 @@ struct efi_runtime_work efi_rts_work;
>  ({									\
>  	efi_rts_work.status = EFI_ABORTED;				\
>  									\
> +	if (!efi_enabled(EFI_RUNTIME_SERVICES)) {			\
> +		pr_info("Aborting! EFI Runtime Services disabled\n");	\

This probaby wants to be pr_info_ince().

Other than that:

      Reviewed-by: Thomas Gleixner <tglx@linutronix.de>

  reply	other threads:[~2018-09-12 18:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-11 19:15 [PATCH V6 0/2] Add efi page fault handler to recover from page Sai Praneeth Prakhya
2018-09-11 19:15 ` [PATCH V6 1/2] efi: Make efi_rts_work accessible to efi page fault handler Sai Praneeth Prakhya
2018-09-11 19:15 ` [PATCH V6 2/2] x86/efi: Add efi page fault handler to recover from page faults caused by the firmware Sai Praneeth Prakhya
2018-09-12 18:56   ` Thomas Gleixner [this message]
2018-09-12 18:58     ` Ard Biesheuvel
2018-09-12 19:02       ` Prakhya, Sai Praneeth
2018-09-12 14:37 ` [PATCH V6 0/2] Add efi page fault handler to recover from page Ard Biesheuvel
2018-09-12 17:32   ` Prakhya, Sai Praneeth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1809122055190.1473@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=ard.biesheuvel@linaro.org \
    --cc=astone@redhat.com \
    --cc=bhsharma@redhat.com \
    --cc=bp@alien8.de \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=sai.praneeth.prakhya@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®