From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Nayna Jain <nayna@linux.vnet.ibm.com>,
"Usyskin, Alexander" <alexander.usyskin@intel.com>,
"Struk, Tadeusz" <tadeusz.struk@intel.com>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH] tpm: tpm_try_transmit() refactor error flow.
Date: Sat, 20 Oct 2018 02:34:22 +0300 (EEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1810200230200.9963@jsakkine-mobl1> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B9D9F5512@hasmsx109.ger.corp.intel.com>
On Thu, 18 Oct 2018, Winkler, Tomas wrote:
>> -----Original Message-----
>> From: Jarkko Sakkinen [mailto:jarkko.sakkinen@linux.intel.com]
>> Sent: Thursday, October 18, 2018 03:15
>> To: Winkler, Tomas <tomas.winkler@intel.com>
>> Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>; Jason Gunthorpe
>> <jgg@ziepe.ca>; Nayna Jain <nayna@linux.vnet.ibm.com>; Usyskin,
>> Alexander <alexander.usyskin@intel.com>; Struk, Tadeusz
>> <tadeusz.struk@intel.com>; linux-integrity@vger.kernel.org; linux-security-
>> module@vger.kernel.org; linux-kernel@vger.kernel.org;
>> stable@vger.kernel.org
>> Subject: Re: [PATCH] tpm: tpm_try_transmit() refactor error flow.
>>
>> On Tue, 16 Oct 2018, Tomas Winkler wrote:
>>> First, rename out_no_locality to out_locality for bailing out on both
>>> tpm_cmd_ready() and tpm_request_locality() failure.
>>
>> This is unnecessary change and technically it is not a rename: the commit
>> message text and the code change do not match. Rename is just a rename
>> (i.e. change a variable name foo to bar).
>
> I'm renaming the label because it doesn't match the code flow anymore,
> I can change the commit message, but you please review the code.
> Tomas
The flow change is unnecessary and does not really have anything to do
with the bug fix. Earlier version was better than this and would have
been fine when taking account the remark from Jason.
/Jarkko
next prev parent reply other threads:[~2018-10-19 23:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 13:37 Tomas Winkler
2018-10-18 0:14 ` Jarkko Sakkinen
2018-10-18 6:06 ` Winkler, Tomas
2018-10-19 23:34 ` Jarkko Sakkinen [this message]
2018-10-20 22:49 ` Winkler, Tomas
2018-10-23 13:27 ` Jarkko Sakkinen
2018-10-23 14:16 ` Winkler, Tomas
2018-10-24 8:59 ` Jarkko Sakkinen
2018-10-24 9:01 ` Winkler, Tomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1810200230200.9963@jsakkine-mobl1 \
--to=jarkko.sakkinen@linux.intel.com \
--cc=alexander.usyskin@intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nayna@linux.vnet.ibm.com \
--cc=stable@vger.kernel.org \
--cc=tadeusz.struk@intel.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®