From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F14A0C43387 for ; Mon, 24 Dec 2018 06:32:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C245321783 for ; Mon, 24 Dec 2018 06:32:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726711AbeLXGcg (ORCPT ); Mon, 24 Dec 2018 01:32:36 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:47060 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725849AbeLXGcf (ORCPT ); Mon, 24 Dec 2018 01:32:35 -0500 X-IronPort-AV: E=Sophos;i="5.56,391,1539640800"; d="scan'208";a="290032572" Received: from abo-91-111-68.mrs.modulonet.fr (HELO hadrien) ([85.68.111.91]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Dec 2018 07:32:33 +0100 Date: Mon, 24 Dec 2018 07:32:33 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: "Darrick J. Wong" cc: kernel-janitors@vger.kernel.org, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/20] xfs: xfs_buf: drop useless LIST_HEAD In-Reply-To: <20181223225118.GH27208@magnolia> Message-ID: References: <1545555435-24576-1-git-send-email-Julia.Lawall@lip6.fr> <1545555435-24576-9-git-send-email-Julia.Lawall@lip6.fr> <20181223225118.GH27208@magnolia> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 23 Dec 2018, Darrick J. Wong wrote: > On Sun, Dec 23, 2018 at 09:57:03AM +0100, Julia Lawall wrote: > > Drop LIST_HEAD where the variable it declares has never > > been used. > > > > The semantic patch that fixes this problem is as follows: > > (http://coccinelle.lip6.fr/) > > > > // > > @@ > > identifier x; > > @@ > > - LIST_HEAD(x); > > ... when != x > > // > > > > Fixes: 26f1fe858f274 ("xfs: reduce lock hold times in buffer writeback") > > Signed-off-by: Julia Lawall > > Looks ok; are you planning to push this whole series directly to Linus > or do you want me to take the two xfs patches through? Please take them. Thanks. julia > > Reviewed-by: Darrick J. Wong > > --D > > > > > --- > > Successfully 0-day tested on 151 configurations. > > > > fs/xfs/xfs_buf.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c > > index b21ea2ba768d..eedc5e0156ff 100644 > > --- a/fs/xfs/xfs_buf.c > > +++ b/fs/xfs/xfs_buf.c > > @@ -1992,7 +1992,6 @@ xfs_buf_delwri_submit_buffers( > > struct list_head *wait_list) > > { > > struct xfs_buf *bp, *n; > > - LIST_HEAD (submit_list); > > int pinned = 0; > > struct blk_plug plug; > > > > >