From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90732C43387 for ; Wed, 16 Jan 2019 10:14:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5F14620840 for ; Wed, 16 Jan 2019 10:14:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389363AbfAPKOT (ORCPT ); Wed, 16 Jan 2019 05:14:19 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:44558 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389058AbfAPKOT (ORCPT ); Wed, 16 Jan 2019 05:14:19 -0500 Received: from p4fea4364.dip0.t-ipconnect.de ([79.234.67.100] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1gjiD3-0004ni-Re; Wed, 16 Jan 2019 11:14:10 +0100 Date: Wed, 16 Jan 2019 11:14:09 +0100 (CET) From: Thomas Gleixner To: Yixun Lan cc: Philipp Zabel , Rob Herring , Neil Armstrong , Kevin Hilman , linux-kernel@vger.kernel.org, Carlo Caione , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Jerome Brunet Subject: Re: [PATCH 1/3] dt-bindings: reset: Add bindings for the Meson-AXG SoC Reset Controller In-Reply-To: Message-ID: References: <20171110084650.31325-1-yixun.lan@amlogic.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 Nov 2018, Thomas Gleixner wrote: Gentle ping. > Yixun, > > On Fri, 10 Nov 2017, Yixun Lan wrote: > > > +/* > > + * > > + * Copyright (c) 2016 BayLibre, SAS. > > + * Author: Neil Armstrong > > + * > > + * Copyright (c) 2017 Amlogic, inc. > > + * Author: Yixun Lan > > + * > > + * SPDX-License-Identifier: (GPL-2.0+ OR BSD) > > There are two things wrong: > > 1) The placement. See Documentation/process/license-rules.rst > > 2) BSD is not a valid license id. You really have to decide which BSD > variant to use. > > Please get that fixed as especially #2 is broken. The goal of using SPDX is > to provide reliable license information for compliance tools. This still is broken: # scripts/spdxcheck.py include/dt-bindings/ include/dt-bindings/reset/amlogic,meson-axg-reset.h: 9:41 Invalid License ID: BSD Thanks, tglx