From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DA88C43381 for ; Fri, 15 Feb 2019 06:25:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D06021872 for ; Fri, 15 Feb 2019 06:25:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730274AbfBOGZe (ORCPT ); Fri, 15 Feb 2019 01:25:34 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:53448 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725924AbfBOGZe (ORCPT ); Fri, 15 Feb 2019 01:25:34 -0500 X-IronPort-AV: E=Sophos;i="5.58,371,1544482800"; d="scan'208";a="369511575" Received: from abo-58-107-68.mrs.modulonet.fr (HELO hadrien) ([85.68.107.58]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Feb 2019 07:25:31 +0100 Date: Fri, 15 Feb 2019 07:25:31 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: wen.yang99@zte.com.cn cc: Markus.Elfring@web.de, Gilles Muller , nicolas.palix@imag.fr, michal.lkml@markovi.net, wang.yi59@zte.com.cn, yamada.masahiro@socionext.com, yellowriver2010@hotmail.com, cheng.shengyu@zte.com.cn, cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v4] coccinelle: semantic patch for missing put_device() In-Reply-To: <201902151422261425412@zte.com.cn> Message-ID: References: 1550126293-27839-1-git-send-email-wen.yang99@zte.com.cn,7c4e26a4-32b9-e1f8-beeb-bfa4fc9e6128@web.de <201902151422261425412@zte.com.cn> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1724339360-1550211931=:2896" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1724339360-1550211931=:2896 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Fri, 15 Feb 2019, wen.yang99@zte.com.cn wrote: > > How do you think about to exchange the word “patch” by “code search” > > at affected places (and in the subject) then? > > Thanks, we‘ll fix it. > > >> In a function, for variables returned by calling of_find_device_by_node(), > > Do variables really get returned? > > The provided pointer should usually be stored somewhere. > > Thank you very much, we will consider this situation and submit a next version to fix it. I don't know what Markus is talking about here, so I'm not sure that a change is needed. > > > * Would you like to pick any software development challenges up around > > inter-procedural data flow (or even escape) analysis for the shown use case? > > We are very interested in doing this work, but currently coccinelle may > not support data flow analysis, and we hope to contribute a little. > > > Would you like to add a SPDX identifier? > > OK, we will add a SPDX identifierfix soon. > > >> + "ERROR: missing put_device;" > >Will change confidence considerations result in another fine-tuning for this message? > > Thank you, we will change "ERROR" to "WARNING". I think ERROR is fine. If it is a real positive than it is a real problem. Warning is for things that look ugly, but don't have any impact on the execution. julia > >> + + " call of_find_device_by_node on line " > >I find that such a split string literal can be unwanted. > > Thank you, we will fix it soon. > > >> + + " and return without releasing.") > >Possible rewording? > >+ + " but without a corresponding object release within this function.") > > Thanks, we will modify it according to your suggestion. > > Regards, > Wen --8323329-1724339360-1550211931=:2896--