From: Julia Lawall <julia.lawall@lip6.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Wen Yang <wen.yang99@zte.com.cn>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
Michal Marek <michal.lkml@markovi.net>,
Yi Wang <wang.yi59@zte.com.cn>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Wen Yang <yellowriver2010@hotmail.com>,
Cheng Shengyu <cheng.shengyu@zte.com.cn>,
cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [v4] coccinelle: semantic patch for missing put_device()
Date: Fri, 15 Feb 2019 09:02:18 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1902150900270.2896@hadrien> (raw)
In-Reply-To: <f4bc7f71-efee-5e0f-3209-82681ddc85be@web.de>
On Fri, 15 Feb 2019, Markus Elfring wrote:
> >> So I plan to modify the following to capture both cases:
> >> -local idexpression id;
> >> +expression id;
> >
> > I'm not sure that this is a good idea.
>
> Why have you got doubts here?
>
>
> > There is likely no need for a put in the latter case.
>
> I have got understanding difficulties for such information.
> What did you try to express with this sentence finally?
The whole goal of the semantic patch is to ensure that put_device is
called when needed. If the value is stored in a structure, then someone
else will likely take care of calling put_device later when the structure
is destroyed.
julia
next prev parent reply other threads:[~2019-02-15 8:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201902151452197117145@zte.com.cn>
2019-02-15 6:55 ` [PATCH v4] " Julia Lawall
2019-02-15 7:50 ` [v4] " Markus Elfring
2019-02-15 8:02 ` Julia Lawall [this message]
2019-02-15 8:19 ` Markus Elfring
[not found] <201902151422261425412@zte.com.cn>
2019-02-15 6:25 ` [PATCH v4] " Julia Lawall
2019-02-15 7:11 ` [v4] " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1902150900270.2896@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Gilles.Muller@lip6.fr \
--cc=Markus.Elfring@web.de \
--cc=cheng.shengyu@zte.com.cn \
--cc=cocci@systeme.lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
--cc=yamada.masahiro@socionext.com \
--cc=yellowriver2010@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®