From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67933C43381 for ; Thu, 28 Mar 2019 14:20:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D2DF2075E for ; Thu, 28 Mar 2019 14:20:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726300AbfC1OUA (ORCPT ); Thu, 28 Mar 2019 10:20:00 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:43880 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725994AbfC1OT7 (ORCPT ); Thu, 28 Mar 2019 10:19:59 -0400 X-IronPort-AV: E=Sophos;i="5.60,280,1549926000"; d="scan'208";a="376181427" Received: from unknown (HELO hadrien) ([195.167.213.123]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2019 15:19:56 +0100 Date: Thu, 28 Mar 2019 15:19:56 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Masahiro Yamada cc: Julia Lawall , Dan Carpenter , Markus Elfring , Wen Yang , Gilles Muller , Michal Marek , Nicolas Palix , Yi Wang , kernel-janitors@vger.kernel.org, Linux Kernel Mailing List , cocci@systeme.lip6.fr Subject: Re: [PATCH] coccinelle: put_device: reduce false positives In-Reply-To: Message-ID: References: <1553321671-27749-1-git-send-email-wen.yang99@zte.com.cn> <179bbdd1-3fcb-bba5-52b3-7f96973c7650@web.de> <20190326084512.GC32590@kadam> <20190326101103.GH32613@kadam> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-504337998-1553782797=:2438" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-504337998-1553782797=:2438 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 28 Mar 2019, Masahiro Yamada wrote: > On Tue, Mar 26, 2019 at 7:16 PM Julia Lawall wrote: > > > > > > > > On Tue, 26 Mar 2019, Dan Carpenter wrote: > > > > > On Tue, Mar 26, 2019 at 10:38:43AM +0100, Julia Lawall wrote: > > > > > > > > > > > > On Tue, 26 Mar 2019, Dan Carpenter wrote: > > > > > > > > > On Sat, Mar 23, 2019 at 09:06:54PM +0100, Julia Lawall wrote: > > > > > > > > > > > > > > > > > > On Sat, 23 Mar 2019, Markus Elfring wrote: > > > > > > > > > > > > > > Don't complain about a return when this function returns "&pdev->dev". > > > > > > > > > > > > > > Would this information qualify to add the tag “Fixes” to the commit message? > > > > > > > > > > > > Fixes tags relate to stable kernels, so that one can see which stable > > > > > > kernels a particular patch should be propagated to. There is no need to > > > > > > propagate patches on semantic patches to stable kernels. People who run > > > > > > stable kernels are interested in their behavior, not the bug finding > > > > > > rules that they contain. > > > > > > > > > > The Fixes tag is not just about stable... For example, we use them for > > > > > statistics to see how quickly bugs get fixed etc. > > > > > > > > OK. But still do we need fixes tags for bug finding rules? Perhaps if > > > > the previous version was really broken, and it would be really undesirable > > > > to use it. > > > > > > It's not worth resending a patch for that, but I probably would use the > > > fixes tag. It depends on your definition of "bug" really... I tell > > > people not to use Fixes for spelling mistakes and unused variables. But > > > I do use the Fixes tag for things like "an off by one in a sanity check > > > which doesn't affect run time because the index is always correct". > > > > OK, thanks. > > > > julia > > I added Fixes: tag, > and applied to linux-kbuild/fixes. Thanks! julia > > Thanks. > > -- > Best Regards > Masahiro Yamada > --8323329-504337998-1553782797=:2438--