From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD6DBC43381 for ; Mon, 1 Apr 2019 19:36:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 84E9020880 for ; Mon, 1 Apr 2019 19:36:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726542AbfDATgQ (ORCPT ); Mon, 1 Apr 2019 15:36:16 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:26817 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725895AbfDATgP (ORCPT ); Mon, 1 Apr 2019 15:36:15 -0400 X-IronPort-AV: E=Sophos;i="5.60,297,1549926000"; d="scan'208";a="301440628" Received: from abo-75-106-68.mrs.modulonet.fr (HELO hadrien) ([85.68.106.75]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Apr 2019 21:36:12 +0200 Date: Mon, 1 Apr 2019 21:36:12 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Neil Armstrong cc: Rob Herring , David Airlie , Daniel Vetter , "Marty E. Plummer" , Tomeu Vizoso , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kbuild-all@01.org Subject: [PATCH] drm/panfrost: fix odd_ptr_err.cocci warnings Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kbuild test robot PTR_ERR should access the value just tested by IS_ERR Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci Fixes: 10f21de123ac ("drm/panfrost: add support for reset lines") CC: Neil Armstrong Signed-off-by: kbuild test robot Signed-off-by: Julia Lawall --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git panfrost-rebase-v2 head: 10f21de123ac13b8c257528b0b1222ebb5650510 commit: 10f21de123ac13b8c257528b0b1222ebb5650510 [7/7] drm/panfrost: add support for reset lines :::::: branch date: 10 hours ago :::::: commit date: 10 hours ago Please take the patch only if it's a positive warning. Thanks! panfrost_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/gpu/drm/panfrost/panfrost_device.c +++ b/drivers/gpu/drm/panfrost/panfrost_device.c @@ -21,7 +21,8 @@ static int panfrost_reset_init(struct pa pfdev->rstc = devm_reset_control_array_get(pfdev->dev, false, true); if (IS_ERR(pfdev->rstc)) { - dev_err(pfdev->dev, "get reset failed %ld\n", PTR_ERR(pfdev->clock)); + dev_err(pfdev->dev, "get reset failed %ld\n", + PTR_ERR(pfdev->rstc)); return PTR_ERR(pfdev->rstc); }