From: Julia Lawall <julia.lawall@lip6.fr>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc: yamada.masahiro@socionext.com,
Julia Lawall <Julia.Lawall@lip6.fr>,
Gilles Muller <Gilles.Muller@lip6.fr>,
nicolas.palix@imag.fr, michal.lkml@markovi.net,
cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Coccinelle: kstrdup: Fix typo in warning messages
Date: Mon, 8 Apr 2019 21:19:41 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1904082119190.2612@hadrien> (raw)
In-Reply-To: <20190408191432.1269-1-rikard.falkeborn@gmail.com>
On Mon, 8 Apr 2019, Rikard Falkeborn wrote:
> Replace 'kstrdep' with 'kstrdup' in warning messages.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Acked-by: Julia.Lawall@lip6.fr
Thanks for the patch!
julia
> ---
> scripts/coccinelle/api/kstrdup.cocci | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/coccinelle/api/kstrdup.cocci b/scripts/coccinelle/api/kstrdup.cocci
> index 09cba54ed0cf..6d13d54a6ee6 100644
> --- a/scripts/coccinelle/api/kstrdup.cocci
> +++ b/scripts/coccinelle/api/kstrdup.cocci
> @@ -76,7 +76,7 @@ p1 << r1.p1;
> p2 << r1.p2;
> @@
>
> -cocci.print_main("WARNING opportunity for kstrdep",p1)
> +cocci.print_main("WARNING opportunity for kstrdup",p1)
> cocci.print_secs("strcpy",p2)
>
> @script:python depends on org@
> @@ -84,7 +84,7 @@ p1 << r2.p1;
> p2 << r2.p2;
> @@
>
> -cocci.print_main("WARNING opportunity for kstrdep",p1)
> +cocci.print_main("WARNING opportunity for kstrdup",p1)
> cocci.print_secs("memcpy",p2)
>
> @script:python depends on report@
> @@ -92,7 +92,7 @@ p1 << r1.p1;
> p2 << r1.p2;
> @@
>
> -msg = "WARNING opportunity for kstrdep (strcpy on line %s)" % (p2[0].line)
> +msg = "WARNING opportunity for kstrdup (strcpy on line %s)" % (p2[0].line)
> coccilib.report.print_report(p1[0], msg)
>
> @script:python depends on report@
> @@ -100,5 +100,5 @@ p1 << r2.p1;
> p2 << r2.p2;
> @@
>
> -msg = "WARNING opportunity for kstrdep (memcpy on line %s)" % (p2[0].line)
> +msg = "WARNING opportunity for kstrdup (memcpy on line %s)" % (p2[0].line)
> coccilib.report.print_report(p1[0], msg)
> --
> 2.21.0
>
>
next prev parent reply other threads:[~2019-04-08 19:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 19:14 Rikard Falkeborn
2019-04-08 19:19 ` Julia Lawall [this message]
2019-07-06 12:18 ` [Cocci] " Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1904082119190.2612@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=rikard.falkeborn@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®