From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F7A0C43219 for ; Sat, 4 May 2019 19:29:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D7A47205F4 for ; Sat, 4 May 2019 19:29:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727463AbfEDTZM (ORCPT ); Sat, 4 May 2019 15:25:12 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:7749 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726596AbfEDTZM (ORCPT ); Sat, 4 May 2019 15:25:12 -0400 X-IronPort-AV: E=Sophos;i="5.60,430,1549926000"; d="scan'208";a="381667713" Received: from abo-60-75-68.mrs.modulonet.fr (HELO hadrien) ([85.68.75.60]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 May 2019 21:25:10 +0200 Date: Sat, 4 May 2019 21:25:10 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Vatsala Narang cc: gregkh@linuxfoundation.org, hadess@hadess.net, hdegoede@redhat.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/7] staging: rtl8723bs: core: Remove return in void function. In-Reply-To: <20190504184358.25632-1-vatsalanarang@gmail.com> Message-ID: References: <20190504184358.25632-1-vatsalanarang@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -5828,8 +5822,6 @@ void survey_timer_hdl(struct timer_list *t) > > > exit_survey_timer_hdl: > - > - return; > } Are you sure that you compiled this code? I'm not sure that it is possible to have a label without a subsequent statement. julia