From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C14FAC04AAF for ; Mon, 20 May 2019 09:51:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A05F420675 for ; Mon, 20 May 2019 09:51:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732374AbfETJvZ (ORCPT ); Mon, 20 May 2019 05:51:25 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:43971 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732361AbfETJvZ (ORCPT ); Mon, 20 May 2019 05:51:25 -0400 X-IronPort-AV: E=Sophos;i="5.60,491,1549926000"; d="scan'208";a="306577628" Received: from unknown (HELO hadrien) ([163.173.90.196]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 May 2019 11:51:23 +0200 Date: Mon, 20 May 2019 11:51:23 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Pavel Machek cc: wen.yang99@zte.com.cn, Markus.Elfring@web.de, cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org, Gilles Muller , yamada.masahiro@socionext.com, michal.lkml@markovi.net, nicolas.palix@imag.fr Subject: Re: Coccinelle: semantic patch for missing of_node_put In-Reply-To: <20190520093303.GA9320@atrey.karlin.mff.cuni.cz> Message-ID: References: <201905171432571474636@zte.com.cn> <20190520093303.GA9320@atrey.karlin.mff.cuni.cz> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 May 2019, Pavel Machek wrote: > Hi! > > > A semantic patch has no access to comments. The only thing I can see to > > do is to use python to interact with some external tools. For example, > > you could write some code to collect the comments in a file and the lines > > on which they occur, and then get the comment that most closely precedes > > the start of the function. > > How dangerous is missing of_node_put? AFAICT it will only result into > very small, one-time memory leak, right? > > Could we make sure these patches are _not_ going to stable? Leaking > few bytes once per boot is not really a serious bug. Agreed. Just tell Sasha. julia > Pavel > > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html >