From: Thomas Gleixner <tglx@linutronix.de>
To: Valentin Schneider <valentin.schneider@arm.com>
Cc: LAK <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] arm64: Avoid pointless schedule_preempt_irq() invocations
Date: Wed, 17 Jul 2019 12:04:55 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1907171203280.1767@nanos.tec.linutronix.de> (raw)
In-Reply-To: <e47e8298-af21-64fa-eac3-6fdfbf11c502@arm.com>
On Wed, 17 Jul 2019, Valentin Schneider wrote:
> On 17/07/2019 09:43, Thomas Gleixner wrote:
> > When preempt_count is zero on return from interrupt then
> > schedule_preempt_irq() is invoked even if TIF_NEED_RESCHED is not set.
> >
> > That does not make sense because schedule_preempt_irq() has to go through a
> > full __schedule() for nothing in that case.
> >
> > Check TIF_NEED_RESCHED and invoke schedule_preempt_irq() only if set.
> >
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>
> Don't we have NEED_RESCHED squashed into preempt count?
>
> 396244692232 ("arm64: preempt: Provide our own implementation of asm/preempt.h")
>
> So the existing check should cover that, unless I'm missing something?
Right. Ignore me.
prev parent reply other threads:[~2019-07-17 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 8:43 Thomas Gleixner
2019-07-17 9:54 ` Valentin Schneider
2019-07-17 10:04 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1907171203280.1767@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=valentin.schneider@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®