From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C91C9C433FF for ; Thu, 1 Aug 2019 15:11:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9B9DD20B7C for ; Thu, 1 Aug 2019 15:11:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732350AbfHAPK7 (ORCPT ); Thu, 1 Aug 2019 11:10:59 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:36395 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728691AbfHAPK6 (ORCPT ); Thu, 1 Aug 2019 11:10:58 -0400 Received: from [5.158.153.52] (helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1htCiy-0001mx-3A; Thu, 01 Aug 2019 17:10:36 +0200 Date: Thu, 1 Aug 2019 17:10:35 +0200 (CEST) From: Thomas Gleixner To: Peter Zijlstra cc: LKML , x86@kernel.org, Ingo Molnar , Sebastian Siewior , Anna-Maria Gleixner , Steven Rostedt , Julia Cartwright , Paul McKenney , Frederic Weisbecker , Oleg Nesterov , kvm@vger.kernel.org, Radim Krcmar , Paolo Bonzini , John Stultz , Andy Lutomirski , "Paul E. McKenney" Subject: Re: [patch 1/5] tracehook: Provide TIF_NOTIFY_RESUME handling for KVM In-Reply-To: <20190801144814.GC31398@hirez.programming.kicks-ass.net> Message-ID: References: <20190801143250.370326052@linutronix.de> <20190801143657.785902257@linutronix.de> <20190801144814.GC31398@hirez.programming.kicks-ass.net> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 1 Aug 2019, Peter Zijlstra wrote: > On Thu, Aug 01, 2019 at 04:32:51PM +0200, Thomas Gleixner wrote: > > +#ifdef CONFIG_HAVE_ARCH_TRACEHOOK > > +/** > > + * tracehook_handle_notify_resume - Notify resume handling for virt > > + * > > + * Called with interrupts and preemption enabled from VMENTER/EXIT. > > + */ > > +void tracehook_handle_notify_resume(void) > > +{ > > + local_irq_disable(); > > + while (test_and_clear_thread_flag(TIF_NOTIFY_RESUME)) { > > + local_irq_enable(); > > + tracehook_notify_resume(NULL); > > + local_irq_disable(); > > + } > > + local_irq_enable(); > > I'm confused by the IRQ state swizzling here, what is it doing? Hmm, right. It's not really needed. Modeled it after the user space return code, but the KVM case is different because it evaluates the TIF bit again before entering the VM with interrupts disabled anyway. I'll remove the brainfart in V2. Thanks, tglx