From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 318DCC31E40 for ; Fri, 9 Aug 2019 10:30:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 03C912166E for ; Fri, 9 Aug 2019 10:30:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406353AbfHIKat (ORCPT ); Fri, 9 Aug 2019 06:30:49 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:6130 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726300AbfHIKas (ORCPT ); Fri, 9 Aug 2019 06:30:48 -0400 X-IronPort-AV: E=Sophos;i="5.64,364,1559512800"; d="scan'208";a="316007832" Received: from portablejulia.rsr.lip6.fr ([132.227.76.63]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Aug 2019 12:30:47 +0200 Date: Fri, 9 Aug 2019 12:30:46 +0200 (CEST) From: Julia Lawall X-X-Sender: julia@hadrien To: Peter Ujfalusi cc: kbuild-all@01.org, Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH] fix odd_ptr_err.cocci warnings Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kbuild test robot PTR_ERR should normally access the value just tested by IS_ERR Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci Fixes: 62c9c1442c8f ("j721e new machine driver wip") Signed-off-by: kbuild test robot Signed-off-by: Julia Lawall --- tree: https://github.com/omap-audio/linux-audio peter/ti-linux-4.19.y/wip head: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a commit: 62c9c1442c8f61ca93e62e1a9d8318be0abd9d9a [34/34] j721e new machine driver wip :::::: branch date: 20 hours ago :::::: commit date: 20 hours ago j721e-evm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/sound/soc/ti/j721e-evm.c +++ b/sound/soc/ti/j721e-evm.c @@ -283,7 +283,7 @@ static int j721e_get_clocks(struct platf parent = devm_clk_get(&pdev->dev, clk_name); kfree(clk_name); if (IS_ERR(parent)) { - ret = PTR_ERR(clocks->parent); + ret = PTR_ERR(parent); if (ret != -EPROBE_DEFER) dev_err(&pdev->dev, "failed to acquire %s': %d\n", prefix, ret); @@ -299,7 +299,7 @@ static int j721e_get_clocks(struct platf parent = devm_clk_get(&pdev->dev, clk_name); kfree(clk_name); if (IS_ERR(parent)) { - ret = PTR_ERR(clocks->parent); + ret = PTR_ERR(parent); if (ret != -EPROBE_DEFER) dev_err(&pdev->dev, "failed to acquire %s': %d\n", prefix, ret);