From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4916EC31E40 for ; Thu, 15 Aug 2019 10:32:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 19F6921743 for ; Thu, 15 Aug 2019 10:32:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730917AbfHOKcJ (ORCPT ); Thu, 15 Aug 2019 06:32:09 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:39533 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730150AbfHOKcI (ORCPT ); Thu, 15 Aug 2019 06:32:08 -0400 Received: from pd9ef1cb8.dip0.t-ipconnect.de ([217.239.28.184] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hyD2z-0001jE-AI; Thu, 15 Aug 2019 12:31:57 +0200 Date: Thu, 15 Aug 2019 12:31:49 +0200 (CEST) From: Thomas Gleixner To: Rahul Tanwar cc: mingo@redhat.com, bp@alien8.de, hpa@zytor.com, x86@kernel.org, andriy.shevchenko@intel.com, alan@linux.intel.com, ricardo.neri-calderon@linux.intel.com, rafael.j.wysocki@intel.com, linux-kernel@vger.kernel.org, qi-ming.wu@intel.com, cheol.yong.kim@intel.com, rahul.tanwar@intel.com Subject: Re: [PATCH 1/3] x86: cpu: Use constant definitions for CPU type In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rahul, On Thu, 15 Aug 2019, Rahul Tanwar wrote: Please use the proper prefix for your patches. x86 uses x86/subsystem: not x86: subsystem: > This patch replaces direct values usage with constant definitions usage > when access CPU models. Please do not use 'This patch'. We already know that this is a patch otherwise you wouldn't have sent it with [PATCH] on the subject line, right? See Documentation/process/submitting-patches.rst and search for 'This patch'. > Signed-off-by: Rahul Tanwar > Suggested-by: Andy Shevchenko > --- > arch/x86/kernel/cpu/intel.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c > index 8d6d92ebeb54..0419fba1ea56 100644 > --- a/arch/x86/kernel/cpu/intel.c > +++ b/arch/x86/kernel/cpu/intel.c > @@ -265,9 +265,9 @@ static void early_init_intel(struct cpuinfo_x86 *c) > /* Penwell and Cloverview have the TSC which doesn't sleep on S3 */ > if (c->x86 == 6) { > switch (c->x86_model) { > - case 0x27: /* Penwell */ > - case 0x35: /* Cloverview */ > - case 0x4a: /* Merrifield */ > + case INTEL_FAM6_ATOM_SALTWELL_MID: /* Penwell */ > + case INTEL_FAM6_ATOM_SALTWELL_TABLET: /* Cloverview */ > + case INTEL_FAM6_ATOM_SILVERMONT_MID: /* Merrifield */ Are these comments really still useful now that the defines are used? I don't think so. Thanks, tglx