From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7452BC3A589 for ; Thu, 15 Aug 2019 14:20:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4E4BB2084D for ; Thu, 15 Aug 2019 14:20:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732925AbfHOOU5 (ORCPT ); Thu, 15 Aug 2019 10:20:57 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:39893 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732816AbfHOOU4 (ORCPT ); Thu, 15 Aug 2019 10:20:56 -0400 Received: from pd9ef1cb8.dip0.t-ipconnect.de ([217.239.28.184] helo=nanos.glx-home) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hyGcW-0006aU-Oy; Thu, 15 Aug 2019 16:20:52 +0200 Date: Thu, 15 Aug 2019 16:20:52 +0200 (CEST) From: Thomas Gleixner To: Ben Luo cc: alex.williamson@redhat.com, linux-kernel@vger.kernel.org, tao.ma@linux.alibaba.com, gerry@linux.alibaba.com, nanhai.zou@linux.alibaba.com, linyunsheng@huawei.com Subject: Re: [PATCH v3 1/3] genirq: enhance error recovery code in free irq In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Aug 2019, Ben Luo wrote: > Per Thomas Gleixner's comments: > 1) free_irq/free_percpu_irq returns if called from IRQ context > 2) move WARN out of the locked region and print out dev_id Please do not describe WHAT the patch is doing, please describe WHY. > Signed-off-by: Ben Luo > --- > kernel/irq/manage.c | 32 ++++++++++++++++++++------------ > 1 file changed, 20 insertions(+), 12 deletions(-) > > diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c > index e8f7f17..6f9b20f 100644 > --- a/kernel/irq/manage.c > +++ b/kernel/irq/manage.c > @@ -1690,7 +1690,11 @@ static struct irqaction *__free_irq(struct irq_desc *desc, void *dev_id) > struct irqaction *action, **action_ptr; > unsigned long flags; > > - WARN(in_interrupt(), "Trying to free IRQ %d from IRQ context!\n", irq); > + if (in_interrupt()) { > + WARN(1, "Trying to free IRQ %d (dev_id %p) from IRQ context!\n", > + irq, dev_id); > + return NULL; > + } if (WARN(in_interrupt(), ."Tr....")) return NULL; Thanks, tglx