From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E305C3A59E for ; Sun, 18 Aug 2019 23:00:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 712FB2186A for ; Sun, 18 Aug 2019 23:00:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rOBHwRkx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726270AbfHRXAZ (ORCPT ); Sun, 18 Aug 2019 19:00:25 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:34225 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726075AbfHRXAZ (ORCPT ); Sun, 18 Aug 2019 19:00:25 -0400 Received: by mail-pg1-f195.google.com with SMTP id n9so13428pgc.1; Sun, 18 Aug 2019 16:00:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=LxVWFPhmFrItVDiQhqvwlh/RdnoTsBda3sGp+wK8hDw=; b=rOBHwRkxTBPOgda6+qfDNpPSj6/ltCFauO4hnmLWCJAnhhI5uvcDV+nBYYtE7ABLgv ftM3nyblZQwhVkofwu7EMqYE2VGWnbM0ukpjhwYoME3a1wSWlMBsyKft0FiH9KjPcg0v M+wkN8qItpygUKe7tVPFELKLkBhBsw8a6uWbdEclmJS6VZ22LMVF+q6I56eiGLkPIprT 7ptQIyE7TB5lYAtYZLcBf/RnULqewCFhYaklqZHKxrqZyRgpdu7qM20BPqj6bQHuPLQm s3vVrShLENFMjeWOC5qtpwFB/yV1Q5t+8iCTAeGRdZtRTlQB7Pl0nRw1EO3CP2PN3Z8p 0wjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=LxVWFPhmFrItVDiQhqvwlh/RdnoTsBda3sGp+wK8hDw=; b=HIbjue317xS4hUxIhI9x5vme8WE+WhPW0T11pUBJ1YgTbwQWLlI5aHsbOIT/VxR2Xq hPmpK2x9qMDe7RKUA8O/igobK7W2vLX/PzU9C3csPXAUCuMgYSgcnhiyVR/VA/7ZP0vt vUEbarbImNZrCaluwrDFVxHqGjiKSVquaUK/2rIJSVtmBiAYssCPrSHHrICzloNyi5To WwAuVDlSaog04j9JRmdvuuzaCZMcgLcDvAH9sopMW040kAa+WghGVGD/SiTW2FlVm8ZP gm7qtjNoukhU84M7AzWNg/umbTR6NM8ZaaE2f/4laA0RkJkmGKDURpvUqudXo8vFLeIY h8hQ== X-Gm-Message-State: APjAAAWsH/TD3g7EgwAQKqRReVVSY2ixwkqXaECK5TRnffxQHj/L9jNG 7nq5WMmWtf5JoX8S8A1uQTZ7IUBf2wM= X-Google-Smtp-Source: APXvYqw7oT/Z7sQLXU4UWr1BGw7eFkLOy40g/+vQzFYRBejZpTxIQDIrsufedkcClsOXFd8OQRszjw== X-Received: by 2002:aa7:8a47:: with SMTP id n7mr22304140pfa.182.1566169224842; Sun, 18 Aug 2019 16:00:24 -0700 (PDT) Received: from mbalantz-desktop (d206-116-172-62.bchsia.telus.net. [206.116.172.62]) by smtp.gmail.com with ESMTPSA id 185sm15700828pfd.125.2019.08.18.16.00.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Aug 2019 16:00:24 -0700 (PDT) From: Mark Balantzyan X-Google-Original-From: Mark Balantzyan Date: Sun, 18 Aug 2019 16:00:20 -0700 (PDT) To: Julian Calaby cc: Mark Balantzyan , sathya.prakash@broadcom.com, suganath-prabu.subramani@broadcom.com, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] lsilogic mpt fusion: mptctl: Fixed race condition around mptctl_id variable using mutexes In-Reply-To: Message-ID: References: <20190815100050.3924-1-mbalant3@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Julian, all, I submitted a patch v4 following Julian's review. A function such as "mptctl_do_mpt_command" I don't think is a setup function and so the race condition (likelihood) remains. Again, this was mainly concerning the usage of "mptctl_id" variable in the driver. My objective was just to make it as safe as possible and improve it. Please accept my patch v4 should it suffice. Thank you, Mark