From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49C4AC3A59E for ; Wed, 21 Aug 2019 17:13:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1AED2216F4 for ; Wed, 21 Aug 2019 17:13:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729832AbfHURNv (ORCPT ); Wed, 21 Aug 2019 13:13:51 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:56323 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728348AbfHURNu (ORCPT ); Wed, 21 Aug 2019 13:13:50 -0400 Received: from p5de0b6c5.dip0.t-ipconnect.de ([93.224.182.197] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1i0UB9-0001pU-5z; Wed, 21 Aug 2019 19:13:47 +0200 Date: Wed, 21 Aug 2019 19:13:41 +0200 (CEST) From: Thomas Gleixner To: Frederic Weisbecker cc: LKML , Oleg Nesterov , Ingo Molnar , Peter Zijlstra , John Stultz , Frederic Weisbecker , Anna-Maria Behnsen Subject: Re: [patch 07/44] posix-cpu-timers: Simplify sighand locking in run_posix_cpu_timers() In-Reply-To: <20190821154245.GA22020@lenoir> Message-ID: References: <20190819143141.221906747@linutronix.de> <20190819143802.038794711@linutronix.de> <20190821120912.GD16213@lenoir> <20190821154245.GA22020@lenoir> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Aug 2019, Frederic Weisbecker wrote: > On Wed, Aug 21, 2019 at 03:25:01PM +0200, Thomas Gleixner wrote: > > On Wed, 21 Aug 2019, Frederic Weisbecker wrote: > > > > > On Mon, Aug 19, 2019 at 04:31:48PM +0200, Thomas Gleixner wrote: > > > > run_posix_cpu_timers() is called from the timer interrupt. The posix timer > > > > expiry always affects the current task which got interrupted. > > > > > > > > sighand locking is only racy when done on a foreign task, which must use > > > > lock_task_sighand(). But in case of run_posix_cpu_timers() that's > > > > pointless. > > > > > > > > sighand of a task can only be dropped or changed by the task itself. Drop > > > > happens in do_exit() > > > > > > Well, that's only in case of autoreap. Otherwise this is dropped by the reaper. > > > > Right, but in the reaper case the task cannot be on the CPU running and > > being interrupted by the tick. I might be missing something subtle though. > > That looks possible. After exit_notify() and until the final schedule(), the exiting task > can execute concurrently with the reaper calling release_task(). Duh, indeed. We only can rely on that when we are in task context and not post state = ZOMBIE. So for now this needs to stay unfortunately, but once we moved the expiry to task work this becomes interesting. /me goes fix.