From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D71C1C3A5A2 for ; Fri, 23 Aug 2019 15:34:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B4F7721019 for ; Fri, 23 Aug 2019 15:34:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394334AbfHWPef (ORCPT ); Fri, 23 Aug 2019 11:34:35 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:35979 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388022AbfHWPef (ORCPT ); Fri, 23 Aug 2019 11:34:35 -0400 Received: from [5.158.153.52] (helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1i1BaD-0005CZ-Hx; Fri, 23 Aug 2019 17:34:33 +0200 Date: Fri, 23 Aug 2019 17:34:33 +0200 (CEST) From: Thomas Gleixner To: Frederic Weisbecker cc: LKML , Oleg Nesterov , Ingo Molnar , Peter Zijlstra , John Stultz , Anna-Maria Behnsen , Christoph Hellwig Subject: Re: [patch V2 17/38] posix-cpu-timers: Create a container struct In-Reply-To: <20190822153212.GU22020@lenoir> Message-ID: References: <20190821190847.665673890@linutronix.de> <20190821192920.819418976@linutronix.de> <20190822153212.GU22020@lenoir> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Aug 2019, Frederic Weisbecker wrote: > On Wed, Aug 21, 2019 at 09:09:04PM +0200, Thomas Gleixner wrote: > > --- a/include/linux/posix-timers.h > > +++ b/include/linux/posix-timers.h > > @@ -62,6 +62,40 @@ static inline int clockid_to_fd(const cl > > return ~(clk >> 3); > > } > > Shouldn't you start the #ifdef CONFIG_POSIX_TIMERS here? > Because you're redefining struct posix_cputimers otherwise. Yeah...