From: Thomas Gleixner <tglx@linutronix.de>
To: Balasubramani Vivekanandan <balasubramani_vivekanandan@mentor.com>
Cc: fweisbec@gmail.com, mingo@kernel.org, peterz@infradead.org,
erosca@de.adit-jv.com, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/1] tick: broadcast-hrtimer: Fix a race in bc_set_next
Date: Thu, 26 Sep 2019 12:01:48 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1909261144250.5528@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20190925142029.13648-2-balasubramani_vivekanandan@mentor.com>
On Wed, 25 Sep 2019, Balasubramani Vivekanandan wrote:
>
> Since it is now allowed to start the hrtimer from the callback, there is
Is now allowed?
> no need for the try to cancel logic. All that is now removed.
Sure I can see that it is removed from the patch, but why and why is it
correct?
> [1]: rcu stall warnings noticed before this patch
>
> [ 26.477514] INFO: rcu_preempt detected stalls on CPUs/tasks:
<SNIP>
I which way is this backtrace giving any useful information about the
problem?
>
> Signed-off-by: Balasubramani Vivekanandan <balasubramani_vivekanandan@mentor.com>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Interesting. You claim authorship on that patch and then you put my SOB
after yours just because you feel entitled to do so?
I surely appreciate the time you spent to analyze the problem and I
wouldn't have said anything if you just would have done the right thing:
1) Write a changelog which explains why the change is actually correct
2) Not wreckage the formatting which I intentionally did for readability
sake
3) Add 'Originally-by: Thomas Gleixner' or at least having the courtesy to
mention that this is not your work.
Thanks,
tglx
next prev parent reply other threads:[~2019-09-26 10:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 14:41 [PATCH V1 0/1] " Balasubramani Vivekanandan
2019-09-18 14:41 ` [PATCH V1 1/1] " Balasubramani Vivekanandan
2019-09-23 19:51 ` Thomas Gleixner
2019-09-24 17:14 ` Eugeniu Rosca
2019-09-25 11:55 ` [PATCH V2 " Balasubramani Vivekanandan
2019-09-25 11:55 ` Balasubramani Vivekanandan
2019-09-25 13:32 ` Balasubramani Vivekanandan
2019-09-25 14:20 ` Balasubramani Vivekanandan
2019-09-25 14:20 ` Balasubramani Vivekanandan
2019-09-26 10:01 ` Thomas Gleixner [this message]
2019-09-26 13:51 ` [PATCH V3 " Balasubramani Vivekanandan
2019-09-26 13:51 ` Balasubramani Vivekanandan
2019-09-26 15:43 ` Eugeniu Rosca
2019-09-27 12:48 ` [tip: timers/core] " tip-bot2 for Balasubramani Vivekanandan
2019-09-20 10:39 ` [PATCH V1 0/1] " Eugeniu Rosca
2019-09-20 10:58 ` Eugeniu Rosca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1909261144250.5528@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=balasubramani_vivekanandan@mentor.com \
--cc=erosca@de.adit-jv.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®