From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A272C4360C for ; Tue, 8 Oct 2019 19:06:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5FEC321835 for ; Tue, 8 Oct 2019 19:06:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729906AbfJHTG6 (ORCPT ); Tue, 8 Oct 2019 15:06:58 -0400 Received: from gentwo.org ([3.19.106.255]:37640 "EHLO gentwo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726098AbfJHTG5 (ORCPT ); Tue, 8 Oct 2019 15:06:57 -0400 Received: by gentwo.org (Postfix, from userid 1002) id 0EC6A3EC01; Tue, 8 Oct 2019 19:06:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 0BD213E886; Tue, 8 Oct 2019 19:06:57 +0000 (UTC) Date: Tue, 8 Oct 2019 19:06:57 +0000 (UTC) From: Christopher Lameter X-X-Sender: cl@www.lameter.com To: Kaitao Cheng cc: akpm@linux-foundation.org, sashal@kernel.org, mhocko@suse.com, osalvador@suse.de, mgorman@techsingularity.net, rppt@linux.ibm.com, dan.j.williams@intel.com, alexander.h.duyck@linux.intel.com, pavel.tatashin@microsoft.com, glider@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song Subject: Re: [PATCH] mm, page_alloc: drop pointless static qualifier in build_zonelists() In-Reply-To: <20190927161416.62293-1-pilgrimtao@gmail.com> Message-ID: References: <20190927161416.62293-1-pilgrimtao@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 28 Sep 2019, Kaitao Cheng wrote: > There is no need to make the 'node_order' variable static > since new value always be assigned before use it. In the past MAX_NUMMNODES could become quite large like 512 or 1k. Large array allocations on the stack are problematic. Maybe that is no longer the case?