From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23487CA9EAF for ; Thu, 24 Oct 2019 05:27:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3B9320856 for ; Thu, 24 Oct 2019 05:27:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437480AbfJXF1B (ORCPT ); Thu, 24 Oct 2019 01:27:01 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:29382 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727485AbfJXF1B (ORCPT ); Thu, 24 Oct 2019 01:27:01 -0400 X-IronPort-AV: E=Sophos;i="5.68,223,1569276000"; d="scan'208";a="407877160" Received: from ip-121.net-89-2-166.rev.numericable.fr (HELO hadrien) ([89.2.166.121]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2019 07:26:59 +0200 Date: Thu, 24 Oct 2019 07:26:59 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Paul Burton cc: Wambui Karuga , gregkh@linuxfoundation.org, outreachy-kernel@googlegroups.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] Re: [PATCH v2 1/5] staging: octeon: remove typedef declaration for cvmx_wqe In-Reply-To: <20191024050011.2ziewy6dkxkcxzvo@lantea.localdomain> Message-ID: References: <20191024050011.2ziewy6dkxkcxzvo@lantea.localdomain> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > If you're making significant changes to this driver, please test them > using the MIPS cavium_octeon_defconfig which is where this driver is > actually used. > > This driver has broken builds a few times recently which makes me very > tempted to ask that we stop allowing it to be built with COMPILE_TEST. > The whole octeon-stubs.h thing is a horrible hack anyway... Wambui, Please figure out what went wrong here. Are there two sets of typedefs that should have been updated? Others, Would it be reasonable to put the information about how the driver should be compied in the TODO file? git grep cavium_octeon_defconfig in the octeon directory turns up nothing. thanks, julia