From: Julia Lawall <julia.lawall@lip6.fr>
To: Cristiane Naves <cristianenavescardoso09@gmail.com>
Cc: outreachy-kernel@googlegroups.com,
Rob Springer <rspringer@google.com>,
Todd Poynor <toddpoynor@google.com>,
Ben Chan <benchan@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] [RESEND PATCH] staging: gasket: Fix lines ending with a '('
Date: Sat, 26 Oct 2019 06:43:46 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1910260642250.2559@hadrien> (raw)
In-Reply-To: <20191025232935.GA813@cristiane-Inspiron-5420>
On Fri, 25 Oct 2019, Cristiane Naves wrote:
> Fix lines ending with a '('. Issue found by checkpatch.
You sent another patch on this file (the one I acked) and they are notin a
series, so Greg won't know how to apply them. Please collect the whole
thing again, and either put both changes in the same patch, or send a
series with the different changes on this file. You could put v2, so that
Greg knows to ignore your other changes on the file.
julia
>
> Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
> ---
> drivers/staging/gasket/gasket_ioctl.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/gasket/gasket_ioctl.c b/drivers/staging/gasket/gasket_ioctl.c
> index d1b3e9a..e3047d3 100644
> --- a/drivers/staging/gasket/gasket_ioctl.c
> +++ b/drivers/staging/gasket/gasket_ioctl.c
> @@ -54,9 +54,9 @@ static int gasket_read_page_table_size(struct gasket_dev *gasket_dev,
> ibuf.size = gasket_page_table_num_entries(
> gasket_dev->page_table[ibuf.page_table_index]);
>
> - trace_gasket_ioctl_page_table_data(
> - ibuf.page_table_index, ibuf.size, ibuf.host_address,
> - ibuf.device_address);
> + trace_gasket_ioctl_page_table_data(ibuf.page_table_index, ibuf.size,
> + ibuf.host_address,
> + ibuf.device_address);
>
> if (copy_to_user(argp, &ibuf, sizeof(ibuf)))
> return -EFAULT;
> @@ -101,9 +101,9 @@ static int gasket_partition_page_table(struct gasket_dev *gasket_dev,
> if (copy_from_user(&ibuf, argp, sizeof(struct gasket_page_table_ioctl)))
> return -EFAULT;
>
> - trace_gasket_ioctl_page_table_data(
> - ibuf.page_table_index, ibuf.size, ibuf.host_address,
> - ibuf.device_address);
> + trace_gasket_ioctl_page_table_data(ibuf.page_table_index, ibuf.size,
> + ibuf.host_address,
> + ibuf.device_address);
>
> if (ibuf.page_table_index >= gasket_dev->num_page_tables)
> return -EFAULT;
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191025232935.GA813%40cristiane-Inspiron-5420.
>
next prev parent reply other threads:[~2019-10-26 4:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 23:29 Cristiane Naves
2019-10-26 4:43 ` Julia Lawall [this message]
2019-10-28 7:57 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1910260642250.2559@hadrien \
--to=julia.lawall@lip6.fr \
--cc=benchan@chromium.org \
--cc=cristianenavescardoso09@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=rspringer@google.com \
--cc=toddpoynor@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®