From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9E75CA9EAE for ; Tue, 29 Oct 2019 08:55:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C781F20663 for ; Tue, 29 Oct 2019 08:55:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730131AbfJ2IzH (ORCPT ); Tue, 29 Oct 2019 04:55:07 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:43265 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729695AbfJ2IzH (ORCPT ); Tue, 29 Oct 2019 04:55:07 -0400 X-IronPort-AV: E=Sophos;i="5.68,243,1569276000"; d="scan'208";a="409212435" Received: from unknown (HELO hadrien) ([91.217.168.176]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Oct 2019 09:55:03 +0100 Date: Tue, 29 Oct 2019 09:55:02 +0100 (CET) From: Julia Lawall X-X-Sender: julia@hadrien To: Masahiro Yamada cc: Julia Lawall , Andy Shevchenko , Joe Perches , Marc Zyngier , Markus Elfring , Himanshu Jha , kernel-janitors@vger.kernel.org, Coccinelle , Alexandre Belloni , Linux Kernel Mailing List , Arnd Bergmann , Bartosz Golaszewski , Gilles Muller , Greg Kroah-Hartman , Linus Torvalds , Linus Walleij , Michal Marek , Nicolas Palix , Thomas Gleixner , YueHaibing Subject: Re: coccinelle: api/devm_platform_ioremap_resource: remove useless script In-Reply-To: Message-ID: References: <693a3b68-a0f1-81fe-40ce-2b6ba189450c@web.de> <868spgzcti.wl-maz@kernel.org> <20191025080843.GG32742@smile.fi.intel.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Oct 2019, Masahiro Yamada wrote: > Hi Julia > > On Fri, Oct 25, 2019 at 5:38 PM Julia Lawall wrote: > > > > > > > > On Fri, 25 Oct 2019, Andy Shevchenko wrote: > > > > > On Fri, Oct 25, 2019 at 12:40:52AM +0900, Masahiro Yamada wrote: > > > > On Sun, Oct 20, 2019 at 7:13 AM Joe Perches wrote: > > > > > On Sat, 2019-10-19 at 21:43 +0100, Marc Zyngier wrote: > > > > > > > Alexandre Belloni used > > > > https://lore.kernel.org/lkml/9bbcce19c777583815c92ce3c2ff2586@www.loen.fr/ > > > > as a reference, but this is not the output from coccicheck. > > > > The patch author just created a wrong patch by hand. > > > > > > Exactly. Removal of the script is a mistake. Like I said before is a healing > > > (incorrect by the way!) by symptoms. > > > > > > > The deleted semantic patch supports MODE=patch, > > > > which creates a correct patch, and is useful. > > > > > > Right! > > > > I ran it on the version of Linux that still has the script: > > > > fe7d2c23d748e4206f4bef9330d0dff9abed7411 > > > > and managed to compile 341 of the generated files in the time I had > > available, and all compiled successfully. > > Yeah, this semantic patch did the correct conversion > as its header part showed the confidence. > > // Confidence: High > > > > > I can let it run again, and see > > how it goes for the rest. Perhaps it would be acceptable if there was no > > report, and people would be forced to use the generated patch? > > I do not think this is the right thing. > MODE=report is the default, and it is fine. > > > > > If someone is writing lots of patches on this issue by hand, then perhaps > > they don't have make coccicheck to produce patches, and then would > > overlook this case completely. > > > > If it would be helpful, I could group the generated patches by maintainer > > or by subdirectory and send them out, if it would be easier to review them > > all at once. > > Yes, please. > > Subsystem maintainers trust you, > so I think it will make things move smoothly. > > After converting most of files, > I want 283ea345934d277e30c841c577e0e2142b4bfcae reverted. OK. I got 477 of the files to compile directly. I can send patches on them, and then look into the issues on the remaining ones (probably configuration issues). julia > > > > > > Anyway, the rule is not in the kernel at the moment. For it's future, I'm > > open to whatever people find best. Personally, I prefer when same things > > are done in the same way - it makes the code easier to understand and > > makes it simpler to address other issues when they arise. > > > We always did the same things in the same way > except commit 283ea345934d277e30c841c577e0e2142b4bfcae > > > > > -- > Best Regards > Masahiro Yamada >