From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 927EEC5DF63 for ; Wed, 6 Nov 2019 18:09:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 67F082067B for ; Wed, 6 Nov 2019 18:09:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732443AbfKFSJQ (ORCPT ); Wed, 6 Nov 2019 13:09:16 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:44988 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726713AbfKFSJP (ORCPT ); Wed, 6 Nov 2019 13:09:15 -0500 Received: from p5b06da22.dip0.t-ipconnect.de ([91.6.218.34] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1iSPk0-00010x-66; Wed, 06 Nov 2019 19:09:12 +0100 Date: Wed, 6 Nov 2019 19:09:11 +0100 (CET) From: Thomas Gleixner To: Eric Dumazet cc: linux-kernel , Eric Dumazet , syzbot Subject: Re: [PATCH] hrtimer: Annotate lockless access to timer->state In-Reply-To: <20191106174804.74723-1-edumazet@google.com> Message-ID: References: <20191106174804.74723-1-edumazet@google.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 6 Nov 2019, Eric Dumazet wrote: > @@ -1013,8 +1013,9 @@ static void __remove_hrtimer(struct hrtimer *timer, > static inline int > remove_hrtimer(struct hrtimer *timer, struct hrtimer_clock_base *base, bool restart) > { > - if (hrtimer_is_queued(timer)) { > - u8 state = timer->state; > + u8 state = timer->state; Shouldn't that be a read once then at least for consistency sake? > + > + if (state & HRTIMER_STATE_ENQUEUED) { > int reprogram; Thanks, tglx